cylc-flow icon indicating copy to clipboard operation
cylc-flow copied to clipboard

Don't demote job failed messages to debug.

Open hjoliver opened this issue 4 months ago • 2 comments

Currently, we demote task messages to DEBUG level if they are more or less redundant with logged state changes.

However, this isn't ideal for job failure messages because,

  • if there are any retries lined up, the state change straight to waiting, with no indication of failure, looks wrong
  • job failures should really always be logged as critical (even if the graph is designed to handle it)

Example:

[scheduling]
    [[graph]]
        R1 = "a"
[runtime]
    [[a]]
        script = false
        execution retry delays = PT5S

Current:

Screenshot (12)

This branch:

Screenshot (11)

Check List

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [x] Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • [x] Tests are included (or explain why tests are not needed).
  • [x] Changelog entry included if this is a change that can affect users
  • [x] Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • [x] If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

hjoliver avatar Oct 11 '24 01:10 hjoliver