cylc-flow
cylc-flow copied to clipboard
Apply CLI clean changes to correct list
Fixes an otherwise unrecorded bug reported by @matthewrmshin .
To Reproduce
Ensure that Cylc will attempt remote reinvokation (global.conf:[scheduler][run hosts]available).
cd ~/cylc-src/workflow
cylc vip -n beeblebrox --no-run-name
Should result in...
$ cylc play # Cylc VIP listing command with arguments.
....
cylc: error: Wrong number of arguments (too few)
Cause
cleanup_sysargv was modifying sys.argv before over-writing it with a new list of args.
Reviewers should
Aside from usual checks reviewers should check this change against cylc-rose tests: The original report involved a rose option config.
Check List
- [x] I have read
CONTRIBUTING.mdand added my name as a Code Contributor. - [x] Contains logically grouped changes (else tidy your branch by rebase).
- [x] Does not contain off-topic changes (use other PRs for other changes).
- [x] Applied any dependency changes to both
setup.cfg(andconda-environment.ymlif present). - [x] Tests are included (or explain why tests are not needed).
- [x]
CHANGES.mdentry included if this is a change that can affect users - [x] ~Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.~ Bug fix does not require docs beyond change log.
- [x] If this is a bug fix, PR should be raised against the relevant
?.?.xbranch.