cylc-flow icon indicating copy to clipboard operation
cylc-flow copied to clipboard

Apply CLI clean changes to correct list

Open wxtim opened this issue 1 year ago • 0 comments

Fixes an otherwise unrecorded bug reported by @matthewrmshin .

To Reproduce

Ensure that Cylc will attempt remote reinvokation (global.conf:[scheduler][run hosts]available).

cd ~/cylc-src/workflow
cylc vip -n beeblebrox --no-run-name

Should result in...

$ cylc play   # Cylc VIP listing command with arguments.
....
cylc: error: Wrong number of arguments (too few)

Cause

cleanup_sysargv was modifying sys.argv before over-writing it with a new list of args.

Reviewers should

Aside from usual checks reviewers should check this change against cylc-rose tests: The original report involved a rose option config.

Check List

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [x] Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • [x] Tests are included (or explain why tests are not needed).
  • [x] CHANGES.md entry included if this is a change that can affect users
  • [x] ~Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.~ Bug fix does not require docs beyond change log.
  • [x] If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

wxtim avatar Mar 07 '24 13:03 wxtim