cylc-flow icon indicating copy to clipboard operation
cylc-flow copied to clipboard

Improved `cylc release` task matching.

Open hjoliver opened this issue 1 year ago • 5 comments

The release command doesn't need to do generic matching of future tasks, because we can only release tasks that are already held - and those are all recorded in the tasks-to-hold list.

That being the case, we can glob-match in both the task pool and the tasks-to-hold list, to identify tasks to release.

Close #5750

Bonus - cylc remove now discards removed tasks from the tasks-to-hold list.

Motivation: one way of handling graph rewind is:

  • hold queued tasks and kill/hold active tasks in the current flow
  • then remove them all before triggering the new flow

The new flow should not get held when it reaches the previously-removed tasks from the original flow.

Check List

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [x] Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • [x] Tests are included (or explain why tests are not needed).
  • [x] CHANGES.md entry included if this is a change that can affect users
  • [x] Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • [x] If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

hjoliver avatar Oct 02 '23 10:10 hjoliver