reinstall changes to `rose-suite.conf`
Fixes two separate, but related bugs (one of which was partially protecting us from the other, except when using rose stem):
1. Rsync Output
cylc reinstall relied on the rsync stdout being empty to choose not to reinstall. Under some circumstances messages such as cannot delete dirctory: opt were causing re-installations unnecessarily.
2. rose-suite.conf reinstallation
Under many circumstances the first bug was allowing re-installation to be triggered when only the rose-suite.conf had changed, despite rose-suite.conf being on the list of files excluded from the rsync.
With the first bug fixed users could change the source rose-suite.conf and have Cylc tell them that nothing required re-installing.
Check List
- [x] I have read
CONTRIBUTING.mdand added my name as a Code Contributor. - [x] Contains logically grouped changes (else tidy your branch by rebase).
- [x] Does not contain off-topic changes (use other PRs for other changes).
- [x] Applied any dependency changes to both
setup.cfgandconda-environment.yml. - [x] Tests will be in a Cylc Rose PR https://github.com/cylc/cylc-rose/pull/178
- [x]
CHANGES.mdentry included if this is a change that can affect users
Couple of small comments, otherwise LGTM, tested as working.
Cylc (re)install does not copy a nested rose-suite.conf file. I don't think this is an issue for now
ATM there is no support for nesting so this is ok.
@wxtim could you rebase onto 8.0.x and fix the changelog.