cylc-flow icon indicating copy to clipboard operation
cylc-flow copied to clipboard

Published 20 hours ago • verified publisher icon cylc

python: Add 3.10 support

Open oliver-sanders opened this issue 3 years ago • 12 comments

Add support for Python 3.10.

Note 3.11 is now nearing release but we can't install our deps with it just yet...

Note: We may need to change the conda-forge metadata for the 8.1.0 release.

  • [x] I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • [x] Contains logically grouped changes (else tidy your branch by rebase).
  • [x] Does not contain off-topic changes (use other PRs for other changes).
  • [x] Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • [x] Tests are included (or explain why tests are not needed).
  • [x] CHANGES.md entry included if this is a change that can affect users
  • [x] Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • [x] If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

oliver-sanders avatar Nov 19 '21 13:11 oliver-sanders

Blocked by pyuv.

oliver-sanders avatar Nov 19 '21 14:11 oliver-sanders

Blocked by pyuv.

does adding libuv as req help?

ngam avatar Nov 19 '21 21:11 ngam

I think pyuv bundles its own libuv?

The issue is that pyuv needs some changes to the C code to work with "3.10".

https://github.com/conda-forge/pyuv-feedstock/pull/12#issuecomment-962069110

oliver-sanders avatar Nov 22 '21 10:11 oliver-sanders

Relates to https://github.com/cylc/cylc-uiserver/pull/260

(perhaps why you're upgrading?)

dwsutherland avatar Nov 29 '21 03:11 dwsutherland

This issue could potentially remove our dependency of pyuv - https://github.com/cylc/cylc-flow/issues/4601

oliver-sanders avatar Jan 21 '22 15:01 oliver-sanders

The pyuv dependency has now been dropped so we can press ahead with this.

oliver-sanders avatar Aug 08 '22 11:08 oliver-sanders

Tried adding 3.11.dev to the fast_tests, however, installation failed - https://github.com/cylc/cylc-flow/runs/7723829198?check_suite_focus=true#step:6:734

Need to wait for our dependencies to release 3.11 wheels.

oliver-sanders avatar Aug 08 '22 12:08 oliver-sanders

Need to wait for our dependencies to release 3.11 wheels.

I'll restore the blocked label for now.

hjoliver avatar Aug 09 '22 23:08 hjoliver

it doesn't block us from 3.10 support though?

MetRonnie avatar Aug 10 '22 11:08 MetRonnie

Sorry, misread!

hjoliver avatar Aug 10 '22 11:08 hjoliver

(couple of random test failures [3.8], rebased to see if they return)

oliver-sanders avatar Aug 11 '22 10:08 oliver-sanders

Poking tests

MetRonnie avatar Aug 12 '22 12:08 MetRonnie

Changelog entry?

MetRonnie avatar Aug 18 '22 14:08 MetRonnie

I don't think we need a changelog for this metadata change caused by a dependency of a dependency, it's a bit meta.

oliver-sanders avatar Aug 18 '22 15:08 oliver-sanders

Thought it might be nice to have "added support for Python 3.10" in the changelog

MetRonnie avatar Aug 18 '22 15:08 MetRonnie

We didn't really "add" it as much as unblock it, feel free to add if you think it's important.

oliver-sanders avatar Aug 18 '22 15:08 oliver-sanders