cylc review: issues inherited from rose bush origin

[sadielbartholomew]

All GitHub issues concerning Rose Bush (to be closed in parallel under metomi/rose) plus those informally registered in the migration PR #2614, collated here to aid systemisation & discussion post-migration to Cylc as Cylc Review.

N.B. there is a new GitHub beta feature to transfer issues across repositories, but better to compile than transfer en-masse.

Can we agree on a (rough) prioritisation order, for anyone who has time to tackle any? We should also decide which 'feature request' issues should await the (later) development stages of a reformed Cylc Review as a component of the new Cylc GUI (#1873).

[Descriptions paraphrased given the overall, up-to-date context.]

Flaws or bugs:

• [ ] https://github.com/cylc/cylc/pull/2614#discussion_r228457075 suite view broadcasts (states & events):
  • [ ] show empty tables not just blank pages (for feedback) for suites with no broadcasts;
  • [ ] raise appropriate HTTP status codes for non-existent relevant file/table & for lack of view permission.
• [ ] suite metadata (see also https://github.com/cylc/cylc/pull/2614#issuecomment-430315439 & metomi/rose#2056 RE metadata division & duplication across rose-suite.info & suite.rc, though not directly relevant) NB not marking these as duplicates as each concerns a separate aspect, as italicised:
  • [ ] metomi/rose#2147: dynamic metadata display (esp. for rosie-suite.info);
  • [ ] metomi/rose#2144: display further (optional) suite info settings.
• [ ] inappropriate icons e.g. for the waiting task state (see bullet point 1 of https://github.com/cylc/cylc/pull/2938#pullrequestreview-223256758)
• [ ] long query strings with default (or multiple custom) task statuses: e.g:

  http://localhost:8080/taskjobs?user=sbarth&suite=consolidation-tutorial&no_fuzzy_time=0&cycles=&tasks=&task_status=runahead&task_status=held&task_status=queued&task_status=expired&task_status=ready&task_status=submit-failed&task_status=submit-retrying&task_status=submitted&task_status=retrying&task_status=running&task_status=failed&task_status=succeeded&job_status=&order=time_desc&per_page=
  

  Since no task status contains a , character, could we instead use a comma to delimit these query parameter values i.e. task_status=runahead,held,queued... instead?

New feature requests (extensions):

• [ ] metomi/rose#2189: view multiple users at once on suites listing page.
• [ ] metomi/rose#2153: display auto-refresh icon on main/all pages.
• [ ] metomi/rose#1308: filter jobs by time run or updated.
• [ ] metomi/rose#1014: group by cycles &/or tasks in task list.
• [ ] metomi/rose#1013: store user preference.

Miscallenous issues:

• [ ] https://github.com/cylc/cylc/pull/2614#issuecomment-433835346 Codacy issues (~350!) on Cylc Review exclusive web (HTML, JS & CSS) files: sift through & either resolve or exclude from Codacy checks, as appropriate.
• [ ] More comprehensive utility documentation: currently there is only that from #2821.

Issues that are no longer issues (to not re-open in Cylc?):

• metomi/rose#1310 & metomi/rose#1009 suite analytics & graphing. Suite analytics will be implemented in the new Cylc GUI (#1873), but this is now being considered a separate domain to Bush/Review.
• metomi/rose#1030: given migration to Cylc, historical rose suite-run logs no longer appropriate to display?

[kinow]

I think all issues linked here have been closed @hjoliver @oliver-sanders ?

[hjoliver]

@wxtim might be the one to confirm this.