complete-alias icon indicating copy to clipboard operation
complete-alias copied to clipboard

consider whether this could be merged into bash-completion

Open calestyo opened this issue 3 years ago • 2 comments

Hey there.

Thanks for your nice tool. It's really something that should be available out-of-the box on every system.

For that reason, would you consider to merge it into bash-completion? That would have the advantage, that it gets more widespread on readily available (sooner or later) in basically every distribution.

The bash-completion maintainer seemed to be open for such an idea, if you'd continue with the maintenance of the tool there.

Cheers, Chris.

calestyo avatar May 11 '21 20:05 calestyo

I'm open to such an idea, too, if the license requirements are satisfied (attribution, disclaimer, etc.). A brief look shows that one uses GPL-2.0 and here it's GPL-3.0. I don't know the exact difference between these two licenses. Maybe they are compatible?

There are technical benefits if these two projects are merged. The code could be simpler and maintainers there could help me check if I'm using their code in the best way. The main reason I chose to make it a separate project is to not let experimental code disturb how bash-completion works. Furthermore, I didn't read every line of bash to make sure the alias parsing here is exactly the same as how bash does it. The goal here is to provide a convenience tool that covers all common use cases, not to be making a standard-compliant tool that behaves the same in every corner case.

Finally, I'm sorry I couldn't guarantee long-term maintainership. I made it for fun and threw it out in case it could be helpful to others, too. For this reason, the disclaimer is essential. If they decide to be serious about merging it into a more widely used tool, then they have to understand how it works and be able to fix bugs when they show up in the merged project. So, I guess the best we can do now is to let bash-completion maintainers take a closer look at complete-alias to see if its quality matches and they are able to integrate and follow-up all the incomings. If they have any questions during the code review or they finally decide it's good to merge, they can open tickets here. I'm not gonna sending pull requests since I don't know how long their code review takes.

cykerway avatar May 12 '21 12:05 cykerway

Guess this one here can be closed with your PR?

calestyo avatar May 02 '23 01:05 calestyo