KiTTY icon indicating copy to clipboard operation
KiTTY copied to clipboard

IDEA: Try to push to mainstream

Open lars18th opened this issue 4 years ago • 1 comments

Hi @cyd01 ,

I know that at time it's difficult that some PuTTY patches will be accepted in the mainstream. However, if the change is list in the main Whislist then I feel it will be more easy. The advantage of pushing some of your changes to the mainstream is that then you'll have less to integrate in future versions.

For example, related to the "key usage confirmation" in the Pageant, these two whises are already implemented by you:

  • PuTTY wish pageant-key-confirm: https://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/pageant-key-confirm.html
  • PuTTY wish pageant-activity-ind: https://www.chiark.greenend.org.uk/~sgtatham/putty/wishlist/pageant-activity-ind.html

Your code is here for the last version: https://github.com/cyd01/KiTTY/blob/3f2c71a3f11bd2ed3df66cbecbd2981b3ef01b69/0.76_My_PuTTY/pageant.c#L844-L849 https://github.com/cyd01/KiTTY/blob/3f2c71a3f11bd2ed3df66cbecbd2981b3ef01b69/0.76_My_PuTTY/pageant.c#L918-L925 https://github.com/cyd01/KiTTY/blob/3f2c71a3f11bd2ed3df66cbecbd2981b3ef01b69/0.76_My_PuTTY/pageant.c#L373

So, I suggest to prepare a patch with only this part and send it to the maintainers. What you think?

lars18th avatar Nov 11 '21 15:11 lars18th

Hi @cyd01 ,

Any interest on this suggestion? Perhaps you won't to do it directly (if you feel it's much effort). But someother could do it with your permission. What you think?

lars18th avatar Jan 10 '22 10:01 lars18th