Craig

Results 30 comments of Craig

Fantastic. With `v0.1.3` it suffices to add a `.license_template_ignore` file to ignore the `libjose` fixtures for now. ``` libjose/tests/fixtures/ ``` Alternatively a change similar to #917 could be applied for...

We use [JcsEd25519Signature2020](https://identity.foundation/JcsEd25519Signature2020/), we do not use `Ed25519Signature2018` nor `Ed25519Signature2020` because they have a different data canonicalisation algorithm (RDF).

We should still add first-class support for `Ed25519VerificationKey2020` (and maybe default to it) for interoperability. It's only the signature I think we should ignore, considering the better alternatives.

> compare (diff?) the old and new document during publishing, and if publishing is successful, attempt to delete all keys that were removed. Indeed that's one of the approaches we...

This is a dependency of [`criterion.rs`](https://github.com/bheisler/criterion.rs), which is only used as a `dev-dependency` for benchmarking. ``` serde_cbor v0.11.2 └── criterion v0.3.5 [dev-dependencies] └── identity v0.4.0 (C:\Work\iota\identity.rs\identity) └── examples v0.1.0 (C:\Work\iota\identity.rs\examples)...

Still an issue but should be fixed with the release of `criterion 0.4`: https://github.com/bheisler/criterion.rs/pull/560

There are two problems presented here: 1. (De)serializable errors for the actor handlers 2. Error handling for bindings (specifically WebAssembly/`wasm-bindgen`) Serializable errors are currently the most important as they prevent...

There are concerns that peppering the code with `Rc` may worsen challenges around memory management with `wasm-bindgen`, since it's unclear if we benefit from garbage collection with `--weak-refs` and even...

`ResolvedDocument` is to be removed with the legacy bindings.

`typedoc` still seems the way to go, it's used successfully by `iota.rs`: https://github.com/iotaledger/iota.rs/blob/14e434b772528b025b07d4e3017a6522100ef1f7/bindings/nodejs/package.json#L29 We could potentially use [`concat-md`](https://www.npmjs.com/package/concat-md) to merge the multiple files: https://github.com/tgreyuk/typedoc-plugin-markdown/issues/59#issuecomment-511218655