gitingest icon indicating copy to clipboard operation
gitingest copied to clipboard

bug: (cli) improper parsing of malformed arguments

Open cyclotruc opened this issue 6 months ago • 5 comments

Image

See screenshot: -include with only one - should throw an error because there's no space after it instead it tries to interpret it as -i include pattern

If anyone wants to tackle this one let me know I'll assign it to you

cyclotruc avatar Jun 25 '25 17:06 cyclotruc

Switching out of Click for the CLI would probably be quite a big refactor of cli.py

Before considering it we should maybe make a list of pros and cons to compare with alternative approaches

I started to look at this issue and it looks like Click doesn't allow to do exact matching with option names. Couldn't we do format checking ourselves AFTER the Click handling in that case?

cyclotruc avatar Jun 26 '25 16:06 cyclotruc

@NeoxAzrot Thank you! You are very welcome to investigate this, shall I assign this Issue to you?

cyclotruc avatar Jun 26 '25 16:06 cyclotruc

I want to take this issue ETA 36 Hr.

ritik4ever avatar Jun 28 '25 01:06 ritik4ever

@ritik4ever @ofux @NeoxAzrot given that all 3 of you manifested interest in this I don't really know who to assign this to I wouldn't mind if someone when ahead and just oppenned a PR as it should be a simple small change

cyclotruc avatar Jun 28 '25 02:06 cyclotruc

I fix this bug easily within 5hours of assigning

Josetic224 avatar Jun 28 '25 22:06 Josetic224

As an avid user of git I'd be honoured to be able to contribute to git

Her-Code avatar Jul 03 '25 11:07 Her-Code

@Her-Code this is gitingest and not git, but thanks a lot for the kind words we take it anyway no giveback 🤷

cyclotruc avatar Jul 03 '25 21:07 cyclotruc

Hello Roman I wanted to sincerely apologize for confusing Gitingest with GitHub earlier-that was entirely on me for not researching properly,I'm sorry about that.After looking into it, I'm really impressed by how Gitingest fetches code from GitHub repos and transforms it into prompt-friendly text. That's such a smart way to streamline documentation and READMEs!

I'd love to work on the issue you mentioned. I'm comfortable with Flask, FastAPI, and Python, and I see this as a great chance to both contribute and learn more about Gitingest(and maybe help promote it!). Let me know how I can dive in.

Thank you for your patience and correction.

Best, Sharon Kahira

On Fri, Jul 4, 2025, 12:15 AM Romain Courtois @.***> wrote:

cyclotruc left a comment (cyclotruc/gitingest#319) https://github.com/cyclotruc/gitingest/issues/319#issuecomment-3033672893

@Her-Code https://github.com/Her-Code this is gitingest and not git, but thanks a lot for the kind words we take it anyway no giveback 🤷

— Reply to this email directly, view it on GitHub https://github.com/cyclotruc/gitingest/issues/319#issuecomment-3033672893, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4CJUOPILMAFJVVCAIELMLT3GWMN3AVCNFSM6AAAAACAD7AF52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMZTGY3TEOBZGM . You are receiving this because you were mentioned.Message ID: @.***>

Her-Code avatar Jul 04 '25 15:07 Her-Code