cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

504 - Copy manifest button

Open sarthakladhwe opened this issue 1 year ago • 1 comments

closes #504

📑 Description

Added a button at the top right corner of the modal which enables user to copy the manifest script

✅ Checks

  • [ ] I have updated the documentation as required
  • [✅] I have performed a self-review of my code

ℹ Additional context

Position of the button: image

sarthakladhwe avatar Aug 12 '24 20:08 sarthakladhwe

@sarthakladhwe thanks for the PR! Can we add the button in the top right corner of the YAML editor? If not, we can keep it as it, but it might look cleaner this way

petar-cvit avatar Aug 12 '24 21:08 petar-cvit

@petar-cvit sure! We are using react-ace for YAML editor and I couldn't find an implementation for 'copy to clipboard' functionality. So I'll just position the button with absolute positioning on top of the editor. For a cleaner look, we could use an Icon component CopyOutlined instead of text.

sarthakladhwe avatar Aug 13 '24 05:08 sarthakladhwe

Sounds good @sarthakladhwe!

petar-cvit avatar Aug 13 '24 07:08 petar-cvit

Hi @petar-cvit, I've implemented the changes, including a tooltip that appears when hovering over the button. If you have any UI preferences or suggestions, I'm happy to make adjustments. Could you please review the code? Thanks!

sarthakladhwe avatar Aug 13 '24 18:08 sarthakladhwe