cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

Expose modules errors on API endpoint

Open petar-cvit opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. Each module renders K8s resources from a template. While doing that, some errors can occur. Those errors are already present on the CRD, but still need to be mapped to the DTO model.

Describe the solution you'd like You will need to add the errors field here and map it in the mapper function.

petar-cvit avatar Jun 17 '24 13:06 petar-cvit

Hi @petar-cvit can I take this issue?

doncicuto avatar Jun 19 '24 09:06 doncicuto

Hey @doncicuto, thanks

petar-cvit avatar Jun 20 '24 09:06 petar-cvit

Hi @petar-cvit I've unassigned this issue to me as I can't see a clear path for this. I'll finish my pending PR first and try to revisit it later

doncicuto avatar Jul 03 '24 07:07 doncicuto

I want to give a shot !

patelajay745 avatar Jul 12 '24 19:07 patelajay745

Hey @patelajay745, sure thing

petar-cvit avatar Jul 16 '24 10:07 petar-cvit

Hello @petar-cvit . Could not get the requirement? Could you please elaborate?

Thank you

patelajay745 avatar Jul 31 '24 21:07 patelajay745

The goal of the issue is to add the ReconciliationStatus to the response when backend is requested for a specific Module here. You will need to add the status to the response and map it from the Module struct

petar-cvit avatar Aug 08 '24 16:08 petar-cvit

Hey @patelajay745, do you have any updates on the issue? Let me know if you have any questions

petar-cvit avatar Aug 19 '24 16:08 petar-cvit

I am not sure. Is this what I'm supposed to do?

Screenshot 2024-08-19 at 9 58 58 PM

patelajay745 avatar Aug 20 '24 02:08 patelajay745

@patelajay745 yeah that looks good, I would just prefer if we put reconciliation status in a nested struct inside dto.Model and add other ReconciliationStatus fields

petar-cvit avatar Aug 20 '24 09:08 petar-cvit

Does that make sense?

Screenshot 2024-08-20 at 1 58 59 PM

Screenshot 2024-08-20 at 2 00 00 PM

patelajay745 avatar Aug 20 '24 18:08 patelajay745

@patelajay745 looks good, but can we not import v1alpha1 package, but create a new dto model? You can open a PR so we can comment there, it will be easier to talk over code 😄

petar-cvit avatar Aug 20 '24 18:08 petar-cvit