cyclops icon indicating copy to clipboard operation
cyclops copied to clipboard

Filter Deployment logs

Open petar-cvit opened this issue 1 year ago • 6 comments

Is your feature request related to a problem? Please describe. Cyclops shows logs for running pods here. Scope of the task is to add a search for logs that you can use to filter out the log you are looking for.

Describe the solution you'd like Add a search bar to the top of the logs modal and show all logs that contain the search input.

petar-cvit avatar Jun 16 '24 20:06 petar-cvit

Hi @petar-cvit would the search box that comes with React Ace would fit your need?

image

doncicuto avatar Jul 03 '24 09:07 doncicuto

@doncicuto Actually yeah, I actually searched for something out of the box like this, but didn't find it. Exactly what we need. Could you open a PR for it?

petar-cvit avatar Jul 03 '24 13:07 petar-cvit

Perfect @petar-cvit you can assign the issue to me then and do you want the Search button to show for every React Ace editor or just for the one for Deployment logs?

doncicuto avatar Jul 03 '24 15:07 doncicuto

Just the one with the logs will do

petar-cvit avatar Jul 03 '24 15:07 petar-cvit

Hey @doncicuto, do you have any updates on the issue?

petar-cvit avatar Aug 08 '24 16:08 petar-cvit

Next week I'll prepare a PR, sorry for the delay, busy summer!

doncicuto avatar Aug 09 '24 09:08 doncicuto

New Quest! image New Quest!

A new Quest has been launched in @cyclops-ui’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Some loot has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #341 to link your PR to this Quest.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 06 '24 11:10 quest-bot[bot]

@quest-bot embark

Sheikh-Abubaker avatar Oct 06 '24 21:10 Sheikh-Abubaker

@Sheikh-Abubaker has embarked on their Quest. 🗡

  • @Sheikh-Abubaker has been on GitHub since 2022.
  • They have merged 37 public PRs in that time.
  • Their swords are blessed with Shell and Smarty magic ✨
  • They have contributed to this repo before.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 06 '24 21:10 quest-bot[bot]

@petar-cvit I'm taking this one!

Sheikh-Abubaker avatar Oct 06 '24 21:10 Sheikh-Abubaker

Hey @petar-cvit a lot has changed since you opened this issue, could you please let me know where this deployment code is located at, the reference you mentioned in the description aren't there any more in the main.

Update: Found out the podlogs code

Sheikh-Abubaker avatar Oct 06 '24 22:10 Sheikh-Abubaker

Would something like this do the job @petar-cvit ? I just tested it locally.

https://github.com/user-attachments/assets/eb3de279-c195-482c-af0b-8efd85c1e1fd

Sheikh-Abubaker avatar Oct 07 '24 00:10 Sheikh-Abubaker

@Sheikh-Abubaker thanks! Can you check if we can implement something similar to https://github.com/cyclops-ui/cyclops/issues/341#issuecomment-2205549708 since it looks more clean in the UI and seems like it supports regex and casing in the search?

petar-cvit avatar Oct 07 '24 13:10 petar-cvit

@quest-bot loot #341

Sheikh-Abubaker avatar Oct 07 '24 21:10 Sheikh-Abubaker

⚠️ Oops... You can only loot in a Pull Request!

Check the docs for more info.

quest-bot[bot] avatar Oct 07 '24 21:10 quest-bot[bot]

🧚 @Sheikh-Abubaker has submitted PR https://github.com/cyclops-ui/cyclops/issues/618 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

quest-bot[bot] avatar Oct 07 '24 21:10 quest-bot[bot]

Quest solved! image Quest solved!

Congratulations! Your efforts have paid off. A PR that solves this Quest has been merged.


@Sheikh-Abubaker, you have been victorious in Quest #341 🗡

💰 To claim your reward follow instructions here

🧚 Thanks to all bold adventurers for attempting this quest! Sign-up to Quira.sh to access more exciting Quests like this one ⚔️

This Quest is now closed ✨

Questions? Check out the docs.

quest-bot[bot] avatar Oct 10 '24 11:10 quest-bot[bot]