On the View Manifest Modal on Rollback page, OK button lacks functionality

[KaradzaJuraj]

Describe the bug

When viewing the manifest, the modal displays two buttons: Cancel and OK. The Cancel button closes the modal, but the OK button lacks functionality. The Cancel button should be removed, and its functionality needs to be moved to the OK button.

To Reproduce

1. Deploy a module through Cyclops
2. Open up the detailed overview of the module
3. Edit the configuration; change something (like the number of replicas) just so this module has a history
4. Click on the Rollback button
5. Click on the Manifest button

Related issue

We had a similar issue with the View Manifest Modal.

[Wasiim105]

@KaradzaJuraj I would like to take this issue. Can you please tell me which part of the code should I look into ?

[hanshal101]

Hey @Wasiim105 you have to make changes to this file. LINK. Here when the user clicks the Manifest in the the module's history there are 2 buttons shown. The OK and the CANCEL. Here we need to make sure that you remove the CANCEL button and make the OK button function work as the CANCEL button. Hope this clears your doubt.

[KaradzaJuraj]

Hey @Wasiim105, you can take this! I will assign this issue to you. You can do as Hanshal suggested above, thanks @hanshal101 🫶 Also, you can check out the PR related to a similar issue.

[Wasiim105]

@hanshal101 I am unable to find the cancel button in History.tsx , there is only an OK button. I have also shared the attachment where only OK button is displaying, could you please help me out ? if I am missing out on something.

[petar-cvit]

Hey @Wasiim105, the button is on the rollback page. You can hit the Rollback button: There, you will find a screen with the history of changes on a particular Module. Here, you can hit the Manifest button that will open a popup with two buttons on the bottom.

The ok button doesn't do anything and the cancel just closes it. You will need to fix those two. You can find the Modal object here.

[Wasiim105]

hey @hanshal101 I followed what you have said but in Rollback page I haven't find any data, It shows me "No Data".

[petar-cvit]

@Wasiim105 Rollback will show you how many times you changed a module. You can try editing a Module a couple of times and you should see entries on this screen

[petar-cvit]

Hey @Wasiim105, did you manage to get any data on the history screen? Let us know if we can help you

[Wasiim105]

@petar-cvit Thankyou for asking, I get the data and I am working on it.