UNSB icon indicating copy to clipboard operation
UNSB copied to clipboard

Potential bug found in ResnetBlock_cond

Open JoanneLin168 opened this issue 10 months ago • 3 comments

https://github.com/cyclomon/UNSB/blob/d1f644f7777e19d5afe5aea3e5cb4bd3afd9b88b/models/ncsn_networks.py#L538

Is there a reason why it is out = layer(x) instead of out = layer(out)?

JoanneLin168 avatar Feb 18 '25 16:02 JoanneLin168

i think x is right. in line 538, out is not defined

suhyeok-jang avatar Mar 30 '25 07:03 suhyeok-jang

I would like to also add that it is in the for loop to pass through each layer of the network. So surely it should be:

out = x
for n,layer in enumerate(self.conv_block):
    out = layer(out)

right?

JoanneLin168 avatar Apr 01 '25 15:04 JoanneLin168

Yes, i think so, the original code has bug

suhyeok-jang avatar Apr 02 '25 03:04 suhyeok-jang