semantic-release-action icon indicating copy to clipboard operation
semantic-release-action copied to clipboard

Tags are not deleted on release failure

Open HeshamMeneisi opened this issue 3 years ago • 2 comments

Describe the bug Tags are not cleared on failure

Workflow

      - name: Checkout
        uses: actions/checkout@v1

      - name: Semantic Release
        id: semantic
        uses: cycjimmy/semantic-release-action@v2
        env:
          GH_TOKEN: ${{ secrets.GH_TOKEN }}
        with:
          extra_plugins: |
            @semantic-release/git
            @semantic-release/exec
            @semantic-release/changelog

       - name: Publish
         run: {some potentially failing code}

Expected behavior The release is not created when the publish step fails and the tag is deleted/not created

Actual Behaviour The release is not created but the tag remains there

HeshamMeneisi avatar Oct 27 '20 05:10 HeshamMeneisi

I'm not sure whether the problem is caused by this action or semantic-release. Have you ever tried to directly use semantic-release to release failure commit?

cycjimmy avatar Nov 02 '20 05:11 cycjimmy

According to your workflow your failure occurs after the semantic-release action ran. I think the current behaviour is correct as the release step completed successfully. Whatever comes after that is not an issue of the action.

You should try to run additional steps inside the @semantic-release/exec plugin, so that it is part of the release step.

saitho avatar Dec 06 '20 16:12 saitho