abao icon indicating copy to clipboard operation
abao copied to clipboard

Fix #184 abao should understand security schemes

Open bpytlik opened this issue 8 years ago • 5 comments

This fixes issue #184. Please let me know if you have any issues with it or any additional testing information you'd like to have.

bpytlik avatar Oct 14 '16 22:10 bpytlik

Coverage Status

Coverage increased (+0.9%) to 89.474% when pulling 841c2de5575b5a1d2bfce7505af66ea0b630792f on bpytlik:security-v0.4-pr into a4ac7ee7b116ea1817a41f2dc865d0dbb963bf79 on cybertk:master.

coveralls avatar Oct 14 '16 22:10 coveralls

Agree with Nikita on his points. Additionally, how do we prove this works in the real world?

plroebuck avatar Oct 17 '16 01:10 plroebuck

Seems like this is more controversial than I expected it would be. The PR satisfies my company's needs. Unfortunately, this is a side project for me, and one I can't really justify spending much more time on. Right now, when I see comments like "how do we prove this works in the real world" I'm inclined to think that adjusting this PR to the feedback will take more time than I can allocate to it. At this point, I'm inclined to close the PR. If someone thinks I'm misunderstanding what they're saying, please let me know.

bpytlik avatar Oct 19 '16 17:10 bpytlik

Sorry. Thought it was a valid question. If we add it, we should be able to prove it works, no?

plroebuck avatar Oct 20 '16 13:10 plroebuck

There are test(s?) included with the pull request which show that we generate tests for the appropriate endpoints. To me, that's the proof that it works. I'm not sure what you mean by "works in the real world".

bpytlik avatar Oct 20 '16 20:10 bpytlik