em icon indicating copy to clipboard operation
em copied to clipboard

Set text color of selection

Open raineorshine opened this issue 1 year ago • 5 comments

Steps to Reproduce

  1. Select part of the text of a thought.
  2. Select a text color.

Current Behavior

The entire thought changes color.

image

Expected Behavior

Only the selection should change color.

Notes

The color formatting implementation needs to change from meta attributes to inline styles.

raineorshine avatar Aug 11 '24 12:08 raineorshine

Hi @raineorshine,

Can external contributors work on this? I have been contributing to open source projects for the last 3 years and have made a significant impact. I'm really interested in contributing to this project.

Thanks!

Krishna2323 avatar Aug 12 '24 19:08 Krishna2323

Certainly! Happy to have your help.

The following milestones are currently assigned to others, but anything else is fair game.

  • https://github.com/cybersemics/em/milestone/18
  • https://github.com/cybersemics/em/milestone/21
  • https://github.com/cybersemics/em/milestone/30
  • https://github.com/cybersemics/em/milestone/31

Let me know if you have any questions about the codebase or how to get started.

raineorshine avatar Aug 12 '24 19:08 raineorshine

That's great, will setup the project and let you know if I face any issues. Can I raise the PR for those issues or I need to be assigned first?

Krishna2323 avatar Aug 12 '24 19:08 Krishna2323

In general you can get started without being assigned, but it's good to check in with me if the instructions are unclear, or if you want to make sure you're taking the right approach.

Note that the above list of milestones are the ones not available to work on. They are already assigned to other developers (even if the individual issues say they are not assigned...).

raineorshine avatar Aug 12 '24 20:08 raineorshine

In general you can get started without being assigned, but it's good to check in with me if the instructions are unclear, or if you want to make sure you're taking the right approach.

Agree on this.

Note that the above list of milestones are the ones not available to work on. They are already assigned to other developers (even if the individual issues say they are not assigned...).

Got it. Thanks for the responses.

Krishna2323 avatar Aug 12 '24 20:08 Krishna2323