wordpress-geo-mashup icon indicating copy to clipboard operation
wordpress-geo-mashup copied to clipboard

How best to add a feature (image overlays)

Open titaniumbones opened this issue 8 years ago • 1 comments

I've just started to work on a custom-geo-mashup that adds the ability to use image overlays. It is very primitive and not at all integrated into the Wordpress workflow.

I've been thinking about it and it seems like a feature that might be of more general use. What would I need to do/learn in order to submit a proper patch request?

the few lines of horrible relevant code are all in custom.js at:

https://github.com/titaniumbones/geo-mashup-custom

It's a bit embarrassing to show at this point...

titaniumbones avatar Mar 30 '16 15:03 titaniumbones

Glad you're having fun hacking with geo mashup! The Mapstraction library at least has a method for image overlays. That project seems to have died unfortunately, but I'd at least see how good the existing support is and maybe make needed improvements to geo mashup's bundled version. That would be a good initial contribution, then a shortcode option could be built on top of it.

Note that there is already a shortcode parameter to load a KML URL.

I did some work a few years ago for the Visible Past project, that might be of interest, though I think it just uses KML attachments.

cyberhobo avatar Mar 31 '16 14:03 cyberhobo