Boris Rybalkin

Results 79 comments of Boris Rybalkin

I do not think I changed anything which may affect this test on windows `pkg/acquisition/modules/file/file_test.go` did I?

@LaurenceJJones I tested this on my running instance seems ok (no tcp involved in local api). Do you have any comments? This is just a step towards total no tcp...

Is there any news or do you want me to help?

> @cyberb I'd rather have unix:///path/to/socket instead of a plain path. What do you think? sure, you will still need a pure path later in the code, but I am...

> Can I prepare a PR for your branch with my suggestions? sure, whatever is the easiest

[mmetc](https://github.com/mmetc) I think I saw somewhere that it is possible to add commits to someone else's PR (never done this myself)

@LaurenceJJones done

@mmetc > I am reviewing, the above snippet is to fix the current version after merging to master. And here is a functional test (09_socket.bats) added functional test and version...

> Sorry it took so long @cyberb, what do you think of #2770 > > Unfortunately I cannot merge your PR directly since the code needed some refactoring first, which...