conjur
conjur copied to clipboard
Metrics Solution Design
Desired Outcome
A Solution Design document exists for adding metrics to Conjur. This is a technical design document whose main goal is to elaborate on how we intend to implement of the feature. This document is expected to highlight any potential concerns around the implementation, address them or provide a plan for resolution that is deemed satisfactory by relevant stakeholders.
Please describe the desired outcome for this PR. Said another way, what was the original request that resulted in these code changes? Feel free to copy this information from the connected issue.
Implemented Changes
Describe how the desired outcome above has been achieved with this PR. In particular, consider:
- What's changed? Why were these changes made?
- How should the reviewer approach this PR, especially if manual tests are required?
- Are there relevant screenshots you can add to the PR description?
Connected Issue/Story
Resolves #[relevant GitHub issue(s), e.g. 76]
CyberArk internal issue link: insert issue ID
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be merged.
Changelog
- [ ] The CHANGELOG has been updated, or
- [ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update
Test coverage
- [ ] This PR includes new unit and integration tests to go with the code changes, or
- [ ] The changes in this PR do not require tests
Documentation
- [ ] Docs (e.g.
README
s) were updated in this PR - [ ] A follow-up issue to update official docs has been filed here: insert issue ID
- [ ] This PR does not require updating any documentation
Behavior
- [ ] This PR changes product behavior and has been reviewed by a PO, or
- [ ] These changes are part of a larger initiative that will be reviewed later, or
- [ ] No behavior was changed with this PR
Security
- [ ] Security architect has reviewed the changes in this PR,
- [ ] These changes are part of a larger initiative with a separate security review, or
- [ ] There are no security aspects to these changes
Code Climate has analyzed commit 2abe75d3 and detected 229 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Bug Risk | 1 |
Style | 228 |
The test coverage on the diff in this pull request is 100.0% (50% is the threshold).
This pull request will bring the total coverage in the repository to 90.9% (0.0% change).
View more on Code Climate.