conjur-api-go icon indicating copy to clipboard operation
conjur-api-go copied to clipboard

Go client doesn't append periods to error messages

Open izgeri opened this issue 4 years ago • 1 comments

At current, the Go client appends periods to error messages. The logic is here: https://github.com/cyberark/conjur-api-go/blob/0a432d72cb5937907b786e6ddfc588586fe18f3e/conjurapi/response/error.go#L47-L61

This results in messages that already have periods at the end showing with double periods. An example from Secretless:

404 Not Found. CONJ00076E Variable dev:variable:foobar is empty or not found..

The Go client should just pass on the errors as-is, and not try to add this formatting.

izgeri avatar Apr 07 '21 21:04 izgeri

Best practices for Golang dictates that error messages should not begin capitalized and should not end with punctuation.

I recommend closing this issue, @jtuttle.

Or at least updating to remove the period(s) instead.

infamousjoeg avatar Sep 07 '23 14:09 infamousjoeg

@doodlesbykumbi Do you know why we originally implemented the ConjurError type to add periods?

szh avatar Jan 17 '25 14:01 szh

This has been fixed internally and will be included in the next release.

szh avatar Feb 21 '25 15:02 szh