vertx3-lang-kotlin icon indicating copy to clipboard operation
vertx3-lang-kotlin copied to clipboard

discussion: using vertx-web router

Open gjesse opened this issue 8 years ago • 4 comments

Hi, I started playing around with this code today, but quickly hit a limitation in that the router provided doesn't support path parameters. with some digging & poking, I ended up with this: https://github.com/gjesse/vertx-kotlin-router, which provides a similar interface but delegates to the standard vertx router. I'm wondering if you'd be amenable to swapping out the existing router implementation with something like what I've got? If so i can work up a proper PR with tests,etc.

gjesse avatar Apr 11 '16 02:04 gjesse

yes, I was thinking about extending bindings to support vertx-web as well. You are welcome to make PR ;)

cy6erGn0m avatar Apr 11 '16 11:04 cy6erGn0m

do you want to keep the barebones router around too, or scrap it?

gjesse avatar Apr 11 '16 18:04 gjesse

@gjesse you could use different package for now but you don't need to be compatible with old router

cy6erGn0m avatar Apr 12 '16 18:04 cy6erGn0m

Ok. Some things have changed & so I don't know when i might be able to get around to this now, but i will attempt to if I'm able.

gjesse avatar Apr 14 '16 17:04 gjesse