Create a Firefox Quantum version of TabFern

[cxw42]

Mentioned in #82 and #99.
Firefox does support the chrome.* API (at least at present), so we don't need to switch to browser.*.

Known issues

• [ ] When creating a new window in FF 64, the tab-created and tab-activated messages arrive before the window-created message (!). Therefore, we need to cache new tabs in the multidex without windows somehow, and flush them out if the window never arrives. I think we can probably stick them in the holding pen. Log:

  Object { "Tab created": 14, ctab: {…} }                            main_tl.js:2549
  Unknown window ID 72 - ignoring                                    main_tl.js:2554
  Object { "Tab activated": 14, activeinfo: {…} }                    main_tl.js:2762
  Object { "Window created": 72, "Restore?": "no", cwin: {…} }       main_tl.js:2134
  Object { "Tab updated": 14, Index: 0, changeinfo: {…}, ctab: {…} } main_tl.js:2633
  

• [ ] Figure out how to handle about:debugging, about:config, and any other URLs that extensions aren't allowed to create (see 5e521435f7cddc4bf3365334783fcd5e5779499e). (Are there any other such URLs? May need to grep the FF source.)

• [x] (Hack added in fdecec30662356c7926b6c363ef63b2815c42172) Update the build pipeline to produce separate Chrome and FF versions. At present, all I know of is that we need to use a different manifest for each browser (see https://github.com/cxw42/TabFern/issues/100#issuecomment-449998383).

• [x] Cannot find "process" from "/" error on load on macOS (edit currently the workaround has to be applied by hand. At least automate that, if nothing else. But first update the customized Brunch based on upstream.)

• [ ] app/win/const.js:openWindowForURL(): On FF:

• the window.create call makes a new tab instead of a new window

• After the tabs.get call, the URL for the settings window is still about:blank. Looks like we need to wait until the tab-load state gets to complete before testing the url.

  • Either that, or just don't use the unwanted-tab code on Firefox and see what happens! :)

[cxw42]

Requested by Ismo Räävi via support request 2018/04/15

[devinrhode2]

Hey @cxw42 what's the status on FF support?

[devinrhode2]

Looks like the steps in "Hacking on TabFern" for the switchover branch might now be right... not sure... Shouldn't a dev change to switchover branch? And branch off of switchover? https://github.com/cxw42/TabFern/wiki/Hacking-on-TabFern

Last but not least, I'm not sure how to use the built extension in firefox!

[cxw42]

@devinrhode2 Unfortunately, I haven't had a chance to work on it. It does load as a temporary add-on without crashing, but I wouldn't consider it particularly usable :) . I would be delighted to have some help! Yes, if you do have any time, I would ask that you please work off switchover if you are able. I am currently focused on #35 and would be delighted to include FF support in the next release as well!

Using the built extension: See Loading temporary add-ons in Firefox. Pick public/manifest.json as the thing to load. See the top comment (https://github.com/cxw42/TabFern/issues/100#issue-282712399) for open concerns I am aware of. Thank you!

[devinrhode2]

I tried loading this, I have the extension icon in the top right in FF, but clicking it doesn't do anything :(

[devinrhode2]

(So I guess that's what the status on FF is :)

[cxw42]

Yep, those are normal (broadly defined :D). Did you see the extension window pop up on its own? Try double-clicking the icon and see if you get the window (double-click = summon to current browser window).

When I load the temporary extension, I get the same manifest errors, but the TF window opens anyway.

[devinrhode2]

Double clicking the icon still does not do anything for me, also tried disabling all extensions except for stylus, restarting, and still nothing for single/double click.

I am using FF 64.0 64-bit, on macOS High Sierra.

When I first load the extension in about:debugging, I see this:

[image: Screen Shot 2018-12-26 at 1.16.38 PM.png]

When I reload I see this:

[image: Screen Shot 2018-12-26 at 12.54.22 PM.png] The last commit in my working directory (from you) - on the switchover branch, is: commit 2deb0684eb30d4f1d230d8fa79df04f073d3d5ed (HEAD -> firefox-work, origin/switchover, origin/firefox-work, switchover) Author: Chris White [email protected] Date: Tue Dec 18 22:01:13 2018 -0500

Remove S.COLLAPSE_ON_PARTIAL_WIN_CLOSE

Don't use the option I started adding in
25752b33290885b25a83bf84ef0b097fee176aea.  It would require winOnRemoved
to receive state information about why the window was closed, and I

don't think this feature is sufficiently valuable to take the memory and complexity hit. Let me know if you disagree!

Also, improve the ergonomics of "collapse on window close".  If you hit
Close on an already-closed window, collapse it.

Mentioned in #35.

-Devin http://devinrhode2.github.io http://devinrhode2.github.io/

On Wed, Dec 26, 2018 at 12:05 PM Chris White [email protected] wrote:

Yep, those are normal (broadly defined :D). Did you see the extension window pop up on its own? Try double-clicking the icon and see if you get the window (double-click = summon to current browser window).

When I load the temporary extension, I get the same manifest errors, but the TF window opens anyway.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cxw42/TabFern/issues/100#issuecomment-450002438, or mute the thread https://github.com/notifications/unsubscribe-auth/AAg8qHXDaOOEdTVMMpWRy1aFkTdGB4F4ks5u87pXgaJpZM4REvjJ .

[cxw42]

@devinrhode2 Unfortunately, the screenshots did not come through. However, I added a fix for the manifest issues, in case that helps. Instead of npx brunch ..., say npm run ff. That will build a public-ff tree. Load public-ff/manifest.json in Firefox and see if that helps any. Thanks!

[devinrhode2]

Original should come through now:

When I first load the extension in about:debugging, I see this:

When I reload I see this:

After pulling that from switchover I see: First load:

Reload:

[cxw42]

Thanks! The screenshots did come through. I am on Windows, which is why I think I might be having trouble replicating. I did try a fresh npm install with all my global modules uninstalled, still without successfully replicating. I can think of three next steps to try:

1. If you have brunch installed globally, remove it --- I am using a tweaked version.

2. (See https://developer.mozilla.org/en-US/docs/Tools/Working_with_iframes if you're not familiar with this.) In the developer console, select the middle iframe (win/main.html). Then say log.setLevel(log.levels.INFO). That may provide more debug information.

3. Would you please send me a copy of your generated public-ff/bg/background.js? I'd like to see if there are any differences.

Thank you for working with me on this!

[devinrhode2]

1. No global brunch
2. Not working, we'll need to get creative here I think. log.setLevel throws a ReferenceError on log
3. Background.js: https://gist.github.com/devinrhode2/86ae0e9e8629ae01ccb0adb142debba4 (this is the only script that appears when I click "edit as html" in the background page)

[devinrhode2]

Some screenshots coming up..

[devinrhode2]

Showed inspecting the location.href of the extension background page, and contrasted with mashable.com - in top right there's a strange little windowing type of button that's for selecting the frame. Not available for the background page. I am surprised that the background page uses iframes though... why is that? I figure the thing to do will be to set the sub-frames to have hijacked console methods that use YourWIndow.sendMessage to log console messages from top frame (only in FF) - or, maybe, we could eliminate usage of iframes.

[cxw42]

iframes

Oh - my fault. The background doesn't have any iframes. That's the main window, so remember the iframe + log for once we get the window to open :D . Sorry for the confusion!

process

OK - you are indeed getting some code I am not!

$ diff -U3 public-ff/bg/background.js background-devin.js
--- public-ff/bg/background.js  2018-12-26 20:01:04.363629700 -0500
+++ background-devin.js 2018-12-26 21:16:51.100429200 -0500
@@ -355,6 +355,7 @@
 ;
 (function() {
 var global = typeof window === 'undefined' ? this : window;
+var process;
 var __makeRelativeRequire = function(require, mappings, pref) {
   var none = {};
   var tryReq = function(name, pref) {
@@ -893,7 +894,8 @@

 });

-;require.alias("path-browserify", "path");require.register("___globals___", function(exports, require, module) {
+;require.alias("path-browserify", "path");
+require.alias("process/browser.js", "process");process = require('process');require.register("___globals___", function(exports, require, module) {

 });})();require('___globals___');

Seems to be the same symptoms as brunch/brunch#1503.

I added the suggested fix from https://github.com/brunch/brunch/issues/1503#issuecomment-320902509 - would you please try the latest commit when you get a chance and let me know if it works?

[devinrhode2]

wow removing those added bits got the extension to just popup when I reloaded the background page!

[cxw42]

Great news! Now is the time for log.setLevel.

Would you please start a new topic branch from this point for Firefox? I'm going to do the same for issue 35. That way we won't step on each other's toes, and the eventual PRs will be cleaner.

If you find anything I haven't listed above, feel free to ping me here or open a separate issue as you see fit.

I am going to update the wiki with some more development info in the next few days. Re. the event-order issue, for example, every tab has to be represented in both the multidex and the jstree. The jstree had a holding-pen node where we can hang the tree node for a new tab before its window arrives.

[devinrhode2]

[cxw42]

@devinrhode2 Is this a success report or a failure report? :D

• Red X -> "actually, button press" message is normal.
• I don't know what h0-main.js is, or what those errors are.
• I do know that until the first item in my top comment is fixed, all the tabs will be off by one in any window created after the TF window opens :( .

[devinrhode2]

Would it be possible to export tabs from TabFern Chrome and import in TabFern Firefox?

[devinrhode2]

The h0-main.js errors were from other extensions

[devinrhode2]

It's a success report

[cxw42]

Re. save data - yes - should be no problem. The save-data file is just JSON.

Ideally, there should be no difference in functionality between Chrome and FF when we're done. I certainly have not intentionally added any differences.

[devinrhode2]

Ok so I haven't switched over yet, figured out I can port active tabs by just bookmarking all tabs, but when I restarted firefox, I had some sort of "browser crashed, do you want to restore session?" from firefox, and saw this:

TabFern is not actually installed, since I'm just loading it from the directory, so probably there's some issue with Tab Center Redux

[cxw42]

Indeed, it may well be an interaction bug. Not sure why the crash would have happened, though. I just found this which looks like it has useful info (most notably, switch to Developer Edition and set xpinstall.signatures.required to false) - I'll try it myself when I get the chance.

[cxw42]

Edited

OK - I tried web-ext without success. However, what did work for me (with commit https://github.com/cxw42/TabFern/commit/72ffa2f83f237deee4fae8c22f0f3b84cc85f6a8 on switchover) is:

• Install Developer Edition
• Set my homepage in Dev. Edition to about:debugging

At one point, something messed up the permissions on public-ff. However, exiting Dev Edition, removing the dir, and recreating seems to have worked fine.

Hacking

• Make sure you have c764b39a5d7b76aa50fbdbb03a13e6be7098b67d or later

• Say npx brunch w --env firefox instead of npm run ff (although the latter will still work).

  • bash alternative: BRUNCH_ENV=firefox npx brunch w

  • cmd alternative:

    set BRUNCH_ENV=firefox
    npx brunch w
    

• Start up FF Dev Edition, hit "Load temporary," and pick the manifest from public-ff.

• When you make changes, brunch w will automatically rebuild the public-ff tree :tada: .

• Hit Ctrl+F5 in the TabFern window and the rebuilt public-ff/win will be loaded from disk. (Ditto for the Settings window.)

• If you change the manifest or background, you will need to go to about:debugging and click "Reload" to see the changes.

[SamirSaidani]

Hi, I'm reporting success with v0.2.0.1340 release and FF 66.0.3 The css is kinda weird, but as far as I've tested, it's working...

Thanks god you did it !

I'd love to tip you, but didn't find anything for that on TabFern webpage...

[cxw42]

@samir-s Thank you! I'll get right on that :D .

Please back up frequently! I don't know what differences between Chrome and Firefox may be lying in wait to cause issues. I look forward to any feedback you may have.

[cxw42]

@devinrhode2 re. "cannot find module process from /" --- I now have an Ubuntu 18.04 setup and am seeing the same. For now I am going to do the manual hack you suggested (removing the lines) :) . If I think of anything better I'll let you know.

Specifically (for the benefit of future readers), after running npx brunch b, I edited public/bg/background.js as follows:

require.alias("process/browser.js", "process");process = require('process');require.register("___globals___", function(exports, require, module) {

was changed to:

//require.alias("process/browser.js", "process");process = require('process');
require.register("___globals___", function(exports, require, module) {

(added // and line break).

My Brunch is somewhat customized, which may be causing an issue. I'll look into it in due course.

[cxw42]

@devinrhode2 Would you please join me at #179? Thanks!