shinyhelper icon indicating copy to clipboard operation
shinyhelper copied to clipboard

{shinyhelper} incompatible with {shinymaterial}

Open cwthom opened this issue 4 years ago • 1 comments

Currently shinyhelper is incompatible with the shinymaterial package - it's a nice package and would be good to support.

The issue is they use open_material_modal instead of shiny::showModal, and material_modal instead of shiny::modalDialog. Optimal solution seems to be:

  • add shinymaterial to 'Suggests'
  • add an argument to observe_helpers to allow user to indicate they're using shinymaterial
  • if TRUE, check with requireNamespace to make sure installed
  • create the modal with shinymaterial variants in this case, and with shiny defaults otherwise

See here for advice and here for other examples in CRAN packages.

cwthom avatar Oct 21 '20 10:10 cwthom

Has anyone created a workaround for this by now? Stumbled across the same problem.

Any other packages that are known to work well with shinymaterial for these purposes? I used Cicerone already, but it's not quite the result I'm aiming for as this provides a tour of the app whereas I want the user to be able to actively choose the domain on which he wants more information.

ghost avatar Mar 02 '22 08:03 ghost