Chris Whinfrey
Chris Whinfrey
## 🎉 Description The [ERC721 EIP](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md) lists: - `safeTransferFrom(address, address, uint256, bytes)` - `safeTransferFrom(address, address, uint256)` - `transferFrom(address, address, uint256)` - `approve(address, uint256)` as `payable` functions. The `payable` modifier should...
### Issue `./zokrates setup` fails and with the error `Illegal instruction`. No `proving.key` or `verifying.key` files are generated but variables.inf is generated. ### Environment Mac OS Sierra Version 10.12.6 zokrates/zokrates...
b2b900f addresses https://github.com/hop-protocol/tob-audit/issues/2 e04326e addresses https://github.com/hop-protocol/tob-audit/issues/3 6781f0b addresses https://github.com/hop-protocol/tob-audit/issues/4 e39dd62 addresses https://github.com/hop-protocol/tob-audit/issues/5 38c3c22 addresses https://github.com/hop-protocol/tob-audit/issues/10 945394e addresses https://github.com/hop-protocol/tob-audit/issues/12
Because `BaseChildTunnel` and `BaseRootTunnel` are meant to be inherited from in external code bases, it would be nice to use a flexible solidity version like OpenZeppelin [does](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v3.4/contracts/token/ERC20/ERC20.sol#L3).
It looks like [2ccb26e](https://github.com/dapperlabs/dapper-contracts/commit/2ccb26e010a2d1091328d13b6c8805b63317c840) reverted #2. Was that intentional? [ERC1271](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1271.md) now specifies the following function signatur. It may be worth re-adding the switch to ERC1654 or updating the interface. ```...
**🧐 Motivation** Generate Merkle roots from leaves on-chain **📝 Details** It would be nice to have a method for generating a Merkle root from leaves like [this one](https://github.com/ethereum-optimism/optimism/blob/f1631a5f7ddb6eb4a342bfbd7d46233a43412f9b/packages/contracts/contracts/libraries/utils/Lib_MerkleTree.sol#L22-L96). Has this...