Cliff Hansen

Some data quality filtering appears to be in order. 

> It would be nice to modify the code so that if fitting fails for some of the IV curves, the function returns nan for those entries. We can't always...

Which IV curve index is that failed one? I would like to isolate and save input data that cause failures, to better understand why the algorithm didn't work.

The `nan`s in the current just after Isc are causing the failure. Can you add this step to your script: ``` # drop nans v_is_nan = np.isnan(voltage) i_is_nan = np.isnan(current)...

> We may want to consider adding the "drop nan" code to fit_sandia_simple I'm open to better handling of nan's, but my current view is that the `fit` functions shouldn't...

Two thoughts: - when using `fit_sandia_simple` you are fitting the single diode equation independently to each IV curve. Where are temperatures obtained? Any deviation between the temperature value, and the...

What is the source of the temperature data?

@wholmgren what do you think about [SunPy's ](https://docs.sunpy.org/en/stable/) documentation structure? Looking around at other projects to find a model for pvlib-python

The Rshunt equation coded in pvlib comes from the first reference ``` [1] K. Sauer, T. Roessler, C. W. Hansen, Modeling the Irradiance and Temperature Dependence of Photovoltaic Modules in...

I'm not opposed on principle to a R_sh helper function but what advantage does that have? No other module model uses that particular expression.