Cliff Hansen

Results 312 comments of Cliff Hansen

@steve-ransome I have the three tutorial notebooks cleaned up and running. There are some parts of `mlfm` functions that are not hit by the tests. Could you take a look...

> Do you think we still need to create and test the 4 numbers separately? I do, so that the tests touch all lines of code which do computations. Sounds...

@pvlib/pvlib-maintainer I think this is ready for a look. Coverage is a bit shy because the tests don't hit all of the try/except blocks.

Thank you, Steve. You and I will likely need to get on another Zoom call to address @adriesse comments.

Is the basic idea here that `GenericLinearModel` acts as a neutral ground between the various temperature models? If I follow correctly: an instance is initialized, a `set` method is used...

From a user point of view, is it practical to consider the public code to a function like ``` newparams = temperature.convert(from='pvsyst', to='faiman', params=) ``` The neutral Class could operate...

I'm -1 on a new module; I think it's fine to put this code in `pvlib.temperature`. I don't think there's a lot of code required for the parameter translator, and...

Naming nitpick: `GLM` is a well-used acronym for generalized linear model, and it does not require a leap of imagination to think a user might assume that `temperature.GLM` is akin...

I'm not in favor of breaking pvsystem into subpackages by model name (SAPM, Desoto, etc.). I am in favor of restructuring pvsystem by modeling step, and writing wrapper functions where...

HI @jpplanted > The returned voltages and currents are not guaranteed to be aligned. I don't understand this statement - could you elaborate? The elements of the voltage and current...