Cliff Hansen

This would be a major design change, and I see the arguments in its favor. @kperrynrel can you discuss this with your colleagues? The proposal is to return `True` for...

Good idea - `fill_value`, `out_of_bounds`, something like that would work.

Hi @abhisheksparikh yes, please do! It will be a big job to put all of that paper's QC algorithm into code so best to break it up as multiple pull...

We can implement the method as published, except when it's clear there's a mistake in the paper, or where we need to close a gap the authors don't describe (such...

I would say implement as published (with the discontinuity) and use the first author's name (Lorenz) to identify the method. The ENDORSE method is slightly different, and could be implemented...

Hi @abhisheksparikh sorry for this delayed response. For this function, I think it is safe to clip $AOI \le 90$ for the upper limit. Effectively, the upper limit of direct...

Hello @abhisheksparikh a quick read of the code looks good, thank you! I'll do a detailed review when you switch it to Ready. I edit .rst files in a text...

@matsuobasho for this particular shading function? No. We're actually considering withdrawing the algorithm from the library. After using it for many locations, it appears this algorithm requires extended days of...

@AdamRJensen what is meant by "bin"? Are you thinking to bin the irradiance (e.g., by interval of 50 W/m2) before making the heat plots? If so, what is the extent...

> put it back in az/el format and apply morphological steps I don't know how to form the morphological elements in a radial coordinate system, I suppose it's possible. In...