Cliff Hansen

I think that flagging low irradiance at nighttime is OK in the context of pvanalytics. The package provides other functions which label day/night periods, and each quality function returns a...

@abhisheksparikh I think we should explain the integer flag values. I don't know if my suggestions will render properly as a web page.

@kandersolar @kperrynrel I think we're far enough along for a first review, if you have time and interest.

> Another partial review. High-level thoughts: > * The gallery example does too much. Simpler would be better. Thanks for this. I needed an outside perspective, and I will overhaul...

@kandersolar see if the example is reviewable now.

thanks @kandersolar one last look or LGTY?

> Would pv-analytics be willing to host this? I'll say yes. There's great interest in this topic. A snow loss algorithm may be a bit different than other algorithms in...

Short answer: I think sensor drift detection algorithms are within the scope for this repository. Due diligence: are there already capabilities in [solardatatools ](https://solar-data-tools.readthedocs.io/en/latest/index.html)or in [rdtools](https://rdtools.readthedocs.io/en/stable/)? Drift suggests slow variation...

I wonder if a ruptures technique would detect an abrupt change in daily, daylit average temperature for the detached sensor. @kperrynrel thoughts on that?

@AdamRJensen if the BSRN tests aren't applied for GHI < 50 W/m2, what do the tests return for such values? I assume they don't roll up to a True/False flag,...