Cliff Hansen

Results 312 comments of Cliff Hansen

> Isn't the problem that the method must be specified when the ModelChain object is instantiated? Yes, and please feel at liberty to edit the issue title and description.

I think the existing function is OK as is because SURFRAD publishes daily files. Its not the intent to use that function to read a year of data. I have...

Hello @Jacc0027 and welcome to this community. I would welcome submission of a function implementing that model. It differs from the existing functions by including parameters for perovskite cells. It...

Hi Jacc0027, I have looked at the code in the attachment. Can you make a pull request? When there are some tests, I think we can start the review process.

After thumbing up, second thought: append `v5` to base layer functions but add a parameter to `ModelChain.with_pvwatts`.

Confirmed. The problem appears to be that `_gti_dirint_lt_90` is always called, without checking if any `aoi` value is less than 90. The test for `gti_dirint` doesn't hit this corner case....

At what level would they be exposed? At the `pvlib.singlediode.bishop88_xxx` functions or at a higher level, e.g., `pvlib.pvsystem.singlediode`?

I support this as long as the interface is common for both the `newton` and `brentq` options.

Currently pvlib-python doesn't include code for near or far-field shading. There are models in literature and some modeling package (e.g., FirstSolar's PlantPredict) are using some of them. pvlib-python is open...

#1017 partially meets this request. I would like to see #758 completed and merged before we close this issue.