Cliff Hansen
Cliff Hansen
I'm not in favor of adding the functions to `pvsystem.py` but that's the only current code module that makes any sense. Most functions return module efficiency `eta` (or help do...
Not a review, rather, thoughts for discussion: - I have a preference for `irradiance.complete_irradiance` because that's the `ModelChain` method that has done a similar operation. - Would the user experience...
Is there an aversion to having e.g. 'ghi' be both an input and output parameter name?
+1 to the proposed strategy. The [Intro Tutorial](https://pvlib-python.readthedocs.io/en/stable/user_guide/introtutorial.html) was intended for beginners, but I think our idea of a beginner was someone who already knew python and had some understanding...
@wholmgren what about an option to clip the air mass as @martinherrerias suggests? Default to no clipping.
~~On further thought, I think the problem is with the extra application of `_tuple_from dfs` on [this line](https://github.com/pvlib/pvlib-python/blob/ef4e31b0caa005c367cb20a6eda4e3b79f963dfe/pvlib/modelchain.py#L822).~~ That line should simply assign ``` self.results.dc = scaled ``` `ModelChain.pvwatts_dc` gets...
bifacial.infinite_sheds.get_irradiance_poa: use of height to pitch ratio instead of height and pitch
@kdebrab this makes sense, although it would involve changing some public functions so may need a deprecation cycle. The parameters were implemented separately because the implementer (me) struggled a bit...
I agree with changing the default. IIRC there is some work by Matt Lave that showed Hay-Davies was mildly better when one starts with satellite-based GHI, and Perez better if...
Overall structure looks OK to me. `spectrum` is a sequence of (frequency, spectral density) pairs - is that right? I'm noodling on the name `Sea`, is there an equivalent concept...
@KWagnerCPR they won't appear in the stable docs until the PR is merged. You can preview the docs here: https://pvlib-python--1497.org.readthedocs.build/en/1497/