fastclass icon indicating copy to clipboard operation
fastclass copied to clipboard

Provide labels in fcc

Open 1ycx opened this issue 4 years ago • 5 comments

I think it would be better if we can provide custom labels as input in the fcc, which if not provided defaults to the usual 1, 2, 3, 4, etc

1ycx avatar May 02 '20 08:05 1ycx

Sure, my initial thoughts were to keep this simple and have labels be equivalent to the number key input. Since the GUI now also features buttons for mouse input it’s more feasible to add this...

I use fcc actually for multiple purposes:

  • rate the quality/ suitability of an image that is already in the right class (I.e. 1 high quality, 2 ok, 3 kinda bad etc)
  • indicate different scopes (I.e. 1 full guitar, 2 only the headstock and neck, 3 only some details of the model)

The idea is to have a way to create different subsets of the data by filtering on this later if needed (I,e, include only the best images, etc.).

One could also use it for plain classification (as I think you have in mind), however for me this is already achieved by giving multiple lines (each line for one class) to fcd

I’m not sure I can work on this the next week(s), however I’m happy to accept a PR that lets the user edit the button content to represent classes 😉

cwerner avatar May 02 '20 12:05 cwerner

I wanted to see If I can contribute in any way. Like a quick change of few lines but then I see there's classes and class methods which I have little experience with ( I use functions normally ) and I was like "continue this maybe sometime later". Also I have little experience with tkinter 😅

1ycx avatar May 02 '20 12:05 1ycx

I was doing the fastai-v3 course on deep learning and there arose the need to to create a dataset

1ycx avatar May 02 '20 12:05 1ycx

No worries. I like the idea... I might give it the shot this weekend actually. Not sure how hard it is to implement this with tk 🤔 I’m no expert either and it still feels pretty archaic to me...

However, as said you might be able to achieve this with fcd alone (if your search queries are for each individual class) and only use fcc to remove bad/ wrong images after the download...

cwerner avatar May 02 '20 12:05 cwerner

One could simply read a small config file for naming the buttons, but I’d aim to have this as an interactive operation within the GUI itself...

cwerner avatar May 02 '20 12:05 cwerner