jsonmapper
jsonmapper copied to clipboard
support enums
I do like the simple implementation, however I don't like that increase in the required PHP version.
The code already uses conditional execution based on PHP_VERSION_ID IIRC, so if possible keep the PHP version as it is.
I consent with SvenRtbg's request.
Good point! I added some fixes to avoid depending on PHP 8.1
Now for the tricky part: Any chances of having a test for this? Phpunit allows conditional execution with @.*** PHP 8.1".
I have added the test. Conditional execution works fine and tests run successfully for php > 7.1
I like it. Maybe add some sentence in the readme about enum support?
Something is wrong with TravisCI, I think that service stopped working some time ago. I'm unable to fix anything, I'm away from my gear.
Added to the readme.
Thanks. The merge is for @cweiske to do.
Checks seem to have passed...
@cweiske Is there any news about this PR merge?
Hope to merge
Closing due to lack of activity.