jsonmapper support enums

support enums

Open pilov-pa opened this issue 2 years ago • 11 comments

Mar 19 '22 13:03 pilov-pa

I do like the simple implementation, however I don't like that increase in the required PHP version.

The code already uses conditional execution based on PHP_VERSION_ID IIRC, so if possible keep the PHP version as it is.

Mar 19 '22 14:03 SvenRtbg

I consent with SvenRtbg's request.

Mar 19 '22 19:03 cweiske

Good point! I added some fixes to avoid depending on PHP 8.1

Mar 19 '22 19:03 pilov-pa

Now for the tricky part: Any chances of having a test for this? Phpunit allows conditional execution with @.*** PHP 8.1".

Mar 20 '22 06:03 SvenRtbg

I have added the test. Conditional execution works fine and tests run successfully for php > 7.1

Mar 21 '22 08:03 pilov-pa

I like it. Maybe add some sentence in the readme about enum support?

Something is wrong with TravisCI, I think that service stopped working some time ago. I'm unable to fix anything, I'm away from my gear.

Mar 21 '22 10:03 SvenRtbg

Added to the readme.

Mar 21 '22 14:03 pilov-pa

Thanks. The merge is for @cweiske to do.

Mar 21 '22 14:03 SvenRtbg

Checks seem to have passed...

Mar 31 '22 21:03 SvenRtbg

@cweiske Is there any news about this PR merge?

Jun 16 '22 07:06 deepMOORE

Hope to merge

Aug 30 '22 07:08 tw2066

Closing due to lack of activity.

Dec 08 '22 20:12 cweiske