composer-patches icon indicating copy to clipboard operation
composer-patches copied to clipboard

make sure not to apply/check patches when running with --lock

Open allanpaiste opened this issue 7 years ago • 3 comments

Make sure that patching is switched off when user only wants to update composer.lock hash by running composer update with --lock flag set.

Addresses https://github.com/cweagans/composer-patches/issues/221

allanpaiste avatar Aug 15 '18 22:08 allanpaiste

Seems reasonable. I was wondering why we do that.

weitzman avatar Oct 11 '18 21:10 weitzman

I think there's a property on one of the Composer objects that we can look at, isn't there? This seems like a really reasonable thing to do - just not 100% sure on the approach.

cweagans avatar Oct 11 '18 21:10 cweagans

Just a heads up that there's lots of documentation that when you change patches in your composer.json file, we've been always advised to run composer update --lock to get the new patches applied. There is no composer update nothing kind of command. We would need new guidance on how to accomplish this.

davereid-pfg avatar May 13 '21 20:05 davereid-pfg

#447 should handle this. I've made a note to ensure that there's some mechanism to force patches to be applied.

cweagans avatar Feb 04 '23 07:02 cweagans