NeRF-SR icon indicating copy to clipboard operation
NeRF-SR copied to clipboard

Hard coded warning

Open ChuhanWang10 opened this issue 3 years ago • 3 comments

Hi,

I tried to render the model by running "bash scripts/test_llff_downX.sh", then I got a hard-coded warning and the testing was interrupted like this:

image

I tried both the pre-trained model you shared and my own trained model. In both cases, the test did not work because of this warning. Can you tell me how to solve this? Thank you!

ChuhanWang10 avatar Jul 29 '22 20:07 ChuhanWang10

Perhaps it is not about hard coding some parameters. It is weird because the execution is just stopped without any error occurring. Do you know how to solve this?

And I am also curious about why the data_rgbs is hard coded as : https://github.com/cwchenwang/NeRF-SR/blob/2d2d76e3c2abc8964620b02bc40fcea7aeac9585/models/nerf_downX_model.py#L331

Will not it change according to the size of data or resolution?

ChuhanWang10 avatar Jul 29 '22 21:07 ChuhanWang10

We test one image for debugging and didn't clean up the code, see here at nerf_downX_model.py: image We have uploaded a new commit to solve this issue, thanks for pointing out. Currently, the testing script for LLFF dataset is a virtual camera path we created (--test_split test in the script) for video demonstration, so it doesn't have ground truth rgbs. That's why we use a hard coded self.data_rgbs, which is just a placeholder for compatibility to previous code. As we only tested this on 1008x756 resolution, we didn't adapt to other resolution because of time, you are welcome to create a pull request to resolve this. In the paper, we report metrics on camera poses in the training set (--test_split test_train in the script).

cwchenwang avatar Jul 30 '22 02:07 cwchenwang