Polymorph crashes game

[vsrz]

Using a wand of polymorph or the spell generally seems to cause bad things to happen. Corpse appears in the top left corner of the map, the mob is invulnerable and invisible, etc. This happens in dungeons and in the city.

I can reproduce the problem both in Linux 2.6 and Win32 so I'm pretty sure it's not a curses issue.

[cwc]

Is this reproducible on master (i.e. without the object class patch)? I'll try to test this soon and see if I can figure out what's up.

If it's not specific to the changes to objects, I'm slightly more inclined to push forward with refactoring, since that work could potentially iron out existing bugs (albeit possibly introducing new ones as well).

[vsrz]

I tested this on the current master and even well before I contributed to the project on https://github.com/cwc/OmegaRPG/commit/e600487a7c5dad996b5909ad272d040d80d5c8a3

It might have been introduced during Monster refactoring.

[cwc]

Gotcha. I'll see if I can determine if it's a simple fix or not.

[cwc]

174f538 should fix this. The new monster's X and Y position were not being set on the actual monster object, so anything that used it (such as drawing) was broken.

Also, I tested the version of Omega that's available on Ubuntu and found that polymorph is similarly bugged in it. :laughing: Yay progress.