react-wordle icon indicating copy to clipboard operation
react-wordle copied to clipboard

Show Invalid Guess Before Submitting

Open ericdrgn opened this issue 3 years ago • 8 comments

Describe the solution you'd like Is there a way to get a word to show that it is invalid before hitting enter on the keyboard? This would require all cells to be filled before doing anything but then once all are filled it would somehow show the word isn't in the valid wordlist. Say changing the color of text to red. I assume this would be another status like present, absent, and correct but it would be active all the time and let a user know a word isn't allowed to be submitted before submitting.

ericdrgn avatar Feb 20 '22 05:02 ericdrgn

This would be a nice feature as it saves the player a submit, a popup and some animation delay.

If we use a new state should we also disable the submit button? If we let the user submit then we don't need a new message or any special handling as the game will state "not in word list".

For example Absurdle handles this by disabling the submit button and changing its text to "not in word list".

It also disables all the letter keys when the current row is full, this might be another feature request, too.

gheja avatar Feb 20 '22 08:02 gheja

It also disables all the letter keys when the current row is full, this might be another feature request, too.

Okay, it would need to be more complicated than this as keys can also act as modifiers that are valid to press even if the row is full.

gheja avatar Feb 20 '22 13:02 gheja

There are a million different things that can be done differently, but should we? I think the goal of this project should be to be a faithful clone of the current Wordle game, not to support every possible tweak that can be thought of.

cc @cwackerfuss , @gheja , @TheKnowles Thoughts?

igitur avatar Feb 20 '22 15:02 igitur

@igitur hard agree.

There a lot of neat things we could add, but maintaining a faithful clone allows a wider audience to add these things as they desire to downstream projects.

A lot of these requests are coming in from already existing takes on wordle, i.e. dordle and quordle show invalid words before submit.

The only exception I'm torn on is adding the archive/past word functionality.

TheKnowles avatar Feb 20 '22 15:02 TheKnowles

The only exception I'm torn on is adding the archive/past word functionality.

We think alike! This is an exception that I'd also love to see. I already started thinking about this, specifically whether the past word should be addressed via date or index.

igitur avatar Feb 20 '22 15:02 igitur

Also very much agree -- with a few specific exceptions that improve quality of life for all (like archive / maybe timer), I think we need to be extra conservative about which additions we make over the features that exist in the original project. How can we make this more clear so people don't spend their time contributing to the project with an idea they had and have it rejected? Perhaps this is something we add to the readme or contributing.md

cwackerfuss avatar Feb 20 '22 15:02 cwackerfuss

Is there a way to use this repo to request help for features specifically for forks then? So that if anyone wants to help figure something out it is more visible here? I know plenty of fork maintainers are constantly looking back to here for things and lots have ideas (like myself) that we can't necessarily figure out how to implement on our own. I don't particularly care if this or the other request I put in make it to this repo if you all think it doesn't benefit everyone (though I believe both of my requests do make the QoL better and my other one I would argue provides better QoL than the archive/timer do) I just want to figure out how to do it.

If we could somehow use this repo to also improve other forks due to its visibility that would be appreciated. That is a big part of open source right? Tons of eyes on it and if certain people have the skill and desire to help make changes/improvements then why not. If another more saavy fork maintaner comes along sees my request and things it would be a great addition to theirs then we could work on it together. But doing that in our own repos we are likely to never see each other's improvements until we start watching them for whatever reason.

I don't know just trying to think about what could be done here since I see a lot of things gettings shot down just because they don't line up with the original but then other things being entertained even though they don't align with the original just because certain people want to see it in this repo. I just think this community has a lot of smart and talented people that are able to make some of these features happen that others are incapable of doing entirely on their own.

ericdrgn avatar Feb 20 '22 17:02 ericdrgn

I've been thinking about this and came to similar conclusion, I think making the game more accessible and supported for wider audience should be allowed (maybe even encouraged) (high contrast mode, special character set support, etc.), while changing the game mechanics (i.e. coming up with a scoring system) should belong to a fork.

With more subtle changes, GUI updates (i.e. smoother animation), ease of use (i.e. pre-indicating an invalid guess (hi, current issue!), pre-filling "correct" characters in subsequent guesses) I am more on the fence.

Perhaps this is something we add to the readme or contributing.md

I agree, and if we decide to go with contributing.md (which would be the better place, IMHO, so the readme doesn't get any longer) we should point to it with a clear "read before you start working on a feature or pull request"-ish message somewhere at the top of the readme.

gheja avatar Feb 20 '22 19:02 gheja