cvxpy icon indicating copy to clipboard operation
cvxpy copied to clipboard

Published 20 hours ago • verified publisher icon cvxpy

Cherrypick/1.1.x

Open SteveDiamond opened this issue 2 years ago • 3 comments

Description

Cherry picks the following PRs:

https://github.com/cvxpy/cvxpy/pull/1882

https://github.com/cvxpy/cvxpy/pull/1880

https://github.com/cvxpy/cvxpy/pull/1852

https://github.com/cvxpy/cvxpy/pull/1851

https://github.com/cvxpy/cvxpy/pull/1844

https://github.com/cvxpy/cvxpy/pull/1835

https://github.com/cvxpy/cvxpy/pull/1829

#1855

#1886

Type of change

  • [ ] New feature (backwards compatible)
  • [ ] New feature (breaking API changes)
  • [ ] Bug fix
  • [x] Other (Documentation, CI, ...)

Contribution checklist

  • [x] Add our license to new files.
  • [x] Check that your code adheres to our coding style.
  • [x] Write unittests.
  • [x] Run the unittests and check that they’re passing.
  • [x] Run the benchmarks to make sure your change doesn’t introduce a regression.

SteveDiamond avatar Aug 31 '22 17:08 SteveDiamond

The tests fail for Python 3.6 because they use the old mosek version. I think this is fine and we can still merge. 1.3 is coming out soon and 1.1 will no longer be supported at that point.

SteveDiamond avatar Aug 31 '22 18:08 SteveDiamond

@SteveDiamond see my comment on your PR that changed the MOSEK test.

rileyjmurray avatar Sep 01 '22 03:09 rileyjmurray

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.4% 97.4% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Sep 01 '22 17:09 sonarqubecloud[bot]

@SteveDiamond please add https://github.com/cvxpy/cvxpy/commit/3fad7747e2f624d455ebaec148a2b906b3cb5a6e to this PR when you get a chance.

rileyjmurray avatar Oct 14 '22 15:10 rileyjmurray

@SteveDiamond I've looked through the PRs since the last release that were classified as bug fixes, but not yet included in the two cherry-pick PRs: #1854 #1859 (only relevant for cherry pick 1.2.x PR) #1871

phschiele avatar Nov 03 '22 21:11 phschiele

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.6% 87.6% Coverage
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 03 '22 22:11 sonarqubecloud[bot]

@SteveDiamond I've looked through the PRs since the last release that were classified as bug fixes, but not yet included in the two cherry-pick PRs: #1854 #1859 (only relevant for cherry pick 1.2.x PR) #1871

Great! I've cherry picked these PRs.

SteveDiamond avatar Nov 03 '22 22:11 SteveDiamond

@SteveDiamond I think that all bug-fix PRs are incorporated, and everything is passing. Both PRs LGTM.

phschiele avatar Nov 04 '22 00:11 phschiele