simple_diarizer icon indicating copy to clipboard operation
simple_diarizer copied to clipboard

Undeclared IPython dependency

Open SageRalph opened this issue 2 years ago • 1 comments

The current package (0.0.12 on PyPI) cannot run without IPython, but this is missing from requirements.txt

Steps to reproduce (outside of a Jupyter notebook):

pip install simple-diarizer

# index.py
from simple_diarizer.diarizer import Diarizer

Output:

File "[redacted]\index.py", line 1, in <module>
    from simple_diarizer.diarizer import Diarizer
File "[redacted]\lib\site-packages\simple_diarizer\diarizer.py", line 13, in <module>
    from .utils import check_wav_16khz_mono, convert_wavfile
File "[redacted]\lib\site-packages\simple_diarizer\utils.py", line 8, in <module>
    from IPython.display import Audio, display
ModuleNotFoundError: No module named 'IPython'

SageRalph avatar Dec 09 '22 11:12 SageRalph

This should have been fixed in 500a80b5c47f34a9edf70eaf019f059fda8e2d14 , released in v0.0.13, let me know if this still happens

cvqluu avatar Dec 12 '22 13:12 cvqluu