cbt icon indicating copy to clipboard operation
cbt copied to clipboard

Create a ScalaXB Plugin

Open Jacoby6000 opened this issue 8 years ago • 9 comments

Most of this seems to work, aside from a class loader issue that's preventing me from testing it.

Any suggestions for improvements welcome while I try to sort it out!

Jacoby6000 avatar Aug 26 '17 21:08 Jacoby6000

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 26 '17 21:08 CLAassistant

@Jacoby6000 in order to sign the CLA you need to add the email address used in your commits to your github account.

cvogt avatar Sep 11 '17 23:09 cvogt

will look into the crash now :)

cvogt avatar Sep 11 '17 23:09 cvogt

Getting closer. This seems be be caused by cbt itself using an older Scala version (2.11.8) than one of the dependencies of the plugin (2.11.11). We could temporarily fix this problem but upgrading cbt's scala version but it would also apply again whenever a new Scala version comes out. Will have to think of a solution for this. Nice find in any case. This would have popped up soon anyways.

cvogt avatar Sep 11 '17 23:09 cvogt

btw. the way I found out is by printing the classloader in the top line of cbt in the StackTrace of the crash. Lib.scala:70

cvogt avatar Sep 11 '17 23:09 cvogt

While I am still working on a more permanent fix, if you rebase your PR on this one: https://github.com/cvogt/cbt/pull/560 you should be unblocked. Upgrading scala to 2.11.11 solved the problem for now. Note that there is still a crash, but it looks like a problem in your plugin this time.

cvogt avatar Sep 12 '17 04:09 cvogt

(#560 currently fails the build, but don't worry about that. It looks like it only affect cross-cbt-version integration, which shouldn't block you here and I'll look into as well)

cvogt avatar Sep 12 '17 04:09 cvogt

Awesome, thanks for looking in to this! I'll poke at it in a bit.

Jacoby6000 avatar Sep 12 '17 19:09 Jacoby6000

I'll work on the tests, since we've addressed that classloader issue

Jacoby6000 avatar Sep 13 '17 19:09 Jacoby6000