tf-lift
tf-lift copied to clipboard
cvlab-epfl
TF-LIFT For Windows
Important Note: Prior to this PR, the development was done on a Windows box which unfortunately shorted during a power outage. The hard drive with these commits was originally thought to be unrecoverable, as was most of the system the code was developed on. I have no way to check the status or quality of the PR as it currently exists on a Windows box as the event prompted me to switch to Linux for development. The Anaconda environments should be re-creatable on Linux.
This collection of commits includes some QoL scripts as well as the results of digging through the code and adding comments or clarifying some logical operations with python functions instead of string addition. It also includes the yml and txt text files for recreating the Anaconda environments I was able to use to run the code with tensorflow-gpu 1.4.0 on Windows. The readme has been updated to reference these scripts for various training and testing commands.
I think I have stripped out any cruft or extraneous developments that aren't actually needed for the code, as this was originally a course project, but if I have missed anything please feel free to remove it. There are some minor changes to the eccv and helpers files under the datasets folder,
Some of the changes here seem irrelevant. For example, there are permission changes. Can you remove those first?
Some of the changes here seem irrelevant. For example, there are permission changes. Can you remove those first?
Whoops, that might be from mounting the Windows backup onto my Linux system. I'll double-check. Don't usually have to think about permissions.
@kmyid Permissions appear to be uniform across my copy of the repository, can you call out anything specific for me to take a closer look at?
I've left the batch .py scripts as executable as that was how they were used, but non-executable files should now be permissioned correctly.
If you look at the diffs, there are still too many changes compared to the master branch, although it is hard to see what really changed. Can you also remove them? Only the parts where things have really changed should be highlighted in PRs so that we can easily keep track.
It looks like a formatting difference on the PR, potentially. Maybe OS line ending differences? I'll take a crack at it tomorrow and see if I can figure out how that happened. Wasn't there when I checked them against the latest version, though I only checked line diffs.
Bradley Koskowich Research Assistant Spatial {Query} Lab MANTIS Lab
From: Kwang Moo Yi [email protected] Sent: Monday, April 13, 2020 11:08:09 PM To: cvlab-epfl/tf-lift [email protected] Cc: Koskowich, Bradley [email protected]; Author [email protected] Subject: Re: [cvlab-epfl/tf-lift] TF-LIFT For Windows (#42)
If you look at the diffs, there are still too many changes compared to the master branch, although it is hard to see what really changed. Can you also remove them? Only the parts where things have really changed should be highlighted in PRs so that we can easily keep track.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cvlab-epfl/tf-lift/pull/42#issuecomment-613214869, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AFTYPVHSGNIECOXCDCRP6ETRMPOSTANCNFSM4MHBNASA.
Awesome thanks. No rush though. And thank you so much for the PR. It really helps.
Cheers, Kwang
I'm going to test these commits before I call them functional, it will take me some time to rebuild and process everything though.