tator
tator copied to clipboard
install.sh fails to perform any error checking, raise exceptions, or take into account proxy-constrained networks.
Problems: Install.sh assumes nothing will go wrong during run. Instead of failing out when something doesn't work, script moves on to subsequent steps dependent on steps that fail. Additionally, the deployment won't work in a web-proxied environment because it calls things that don't appear to be proxy-aware.
Reproduce: Isolate a Tator system on a network that must use a simple pass-through web proxy (eg Squid w/ no clever filtering), watch things break.
Thanks for the issue. This is currently an untested network configuration for the install script. We definitely would welcome a PR to resolve any of these issues but we will keep the issue open in the meantime, especially not stopping on failure should be handled. You may want to take a look at the install guide for developers, which basically breaks the install script into manual steps.
OBE'd by #1172.