react-planner icon indicating copy to clipboard operation
react-planner copied to clipboard

Modern Tooling Recommendations

Open jakeNiemiec opened this issue 6 years ago • 6 comments

The purpose of this PR is to make react-planner more consumable by modern development environments. I apologize for the horrific amount of files changed (these are duplicated build files).

  • treat this lib like a lib instead of a final product, this means no intermediate transpiling and no devDependencies
  • add buildfiles to .gitIgnore
  • ES6 Uglifyjs
  • better version detection
  • npm run command "profile" for examining your webpack config on https://webpack.github.io/analyse/
  • enabled the devserver overlay
  • optimized CommonsChunkPlugins
I could take this part out if unwanted:
  • semantic release, this will automate your releases. Here is a test of that: image
  • version set to 0.0.0 for semantic versioning screen shot 2017-11-08 at 3 21 13 pm

As you can see, after you commit travis will run publish and postpublish commands automatically. Since npm run build was run before npm publish, your build files are included in the npm package (react-planner), but not under version control.

jakeNiemiec avatar Nov 08 '17 20:11 jakeNiemiec

Have you by any chance tried to build this component into an angular application?

rfarren01 avatar Aug 14 '18 00:08 rfarren01

@rfarren01 Have you by any chance tried to build this component into an angular application?

Having built in both React & Angular, I would highly discourage it. React-planner works well with react because of the low component overhead whereas Angular has a very high component overhead.

Doable, but you would not be playing to Angular's strengths.

jakeNiemiec avatar Aug 14 '18 17:08 jakeNiemiec

Awesome, this one comment has helped us make a crucial business decision, thanks jakeNiemiec for the fast reply Do you have any examples of your application or is it all client based dev?

rfarren01 avatar Aug 14 '18 21:08 rfarren01

I built my app from the ground up using lessons learned from this repo. image image

Basically: it uses Redux to organize controlling component based SVGs. You need a really good idea of all the moving parts (eg panning/zooming 👆) to get the same effect.

But this PR is about webpack, @rfarren01 feel free to email me if you have any other questions.

jakeNiemiec avatar Aug 14 '18 21:08 jakeNiemiec

Thanks @jakeNiemiec , I have just sent you an email

rfarren01 avatar Aug 27 '18 11:08 rfarren01

I built my app from the ground up using lessons learned from this repo. image image

Basically: it uses Redux to organize controlling component based SVGs. You need a really good idea of all the moving parts (eg panning/zooming 👆) to get the same effect.

But this PR is about webpack, @rfarren01 feel free to email me if you have any other questions.

Hello @jakeNiemiec,

How can we have the same result we saw on your screenshot ? (Maybe you could share your source code ?)

robinalexandre avatar Jan 27 '22 19:01 robinalexandre