cvat
cvat copied to clipboard
Move `--no-binary=lxml,xmlsec` into the Dockerfile
Motivation and context
The intention was for this option to only be set in the production requirements file, but due to how pip-compile-multi works, it ends up leaking into all other files too. Moving it to the Dockerfile fixes this.
How has this been tested?
I re-ran the Docker build to make sure lxml and xmlsec are actually built from source.
Checklist
- [x] I submit my changes into the
developbranch - ~~[ ] I have created a changelog fragment~~
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- ~~[ ] I have linked related issues (see GitHub docs)~~
- ~~[ ] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)~~
License
- [x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
-
New Features
- Updated dependency management to allow binary distributions for
lxmlandxmlsec, improving installation flexibility.
- Updated dependency management to allow binary distributions for
-
Bug Fixes
- Adjusted the specification for
dj-rest-authto ensure correct package resolution during installation.
- Adjusted the specification for
-
Chores
- Cleaned up formatting in requirement files for better readability.
Walkthrough
The changes involve modifications to several requirements files related to Python package management. Key alterations include the removal of --no-binary directives for the lxml and xmlsec packages, allowing for binary installations. Additionally, there is a minor formatting change in the specification of the dj-rest-auth package. Overall, the updates simplify the dependency management process without altering the core functionality of the application.
Changes
| Files | Change Summary |
|---|---|
cvat/requirements/all.txt, |
Removed --no-binary lxml and --no-binary xmlsec, allowing for binary distributions of these packages. |
cvat/requirements/development.txt, |
Removed --no-binary lxml and --no-binary xmlsec, simplifying package installation. |
cvat/requirements/production.in, |
Changed lxml and xmlsec from no-binary to allowing binary installations. |
cvat/requirements/production.txt |
Removed --no-binary lxml and --no-binary xmlsec. |
cvat/requirements/base.txt |
Changed dj-rest-auth[with-social]==5.0.2 to dj-rest-auth[with_social]==5.0.2. |
cvat/requirements/testing.txt |
Removed a blank line for formatting purposes. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant App
participant PackageManager
User->>App: Request to install packages
App->>PackageManager: Process installation
PackageManager->>PackageManager: Check dependencies
PackageManager->>PackageManager: Install dependencies (binary if available)
PackageManager-->>App: Return installation status
App-->>User: Confirm package installation
🐰 In the meadow where bunnies play,
The packages dance, hip-hip-hooray!
No more binaries to chase away,
With simpler paths, we hop all day!
Let's celebrate, with joy and cheer,
For smoother installs, we hold so dear! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@Marishka17 What do you think?
@SpecLad, I liked when --no-binary lxml,xmlsec was in the file with production requirements because all requirements' details were in one place. However, that approach required updating generated .txt files manually. That was not convenient and obviously generated files should not be updated manually. So, thanks, that fixed that.
I would only ask to create PR in the private repo just to be sure that authentication tests pass (before merging this one).
Alright, I tested it.