cvat icon indicating copy to clipboard operation
cvat copied to clipboard

Upgrade React and Antd till the latest version

Open bsekachev opened this issue 1 year ago • 11 comments

Motivation and context

  • [x] Annotation menu
  • [x] OpenCV is not loaded automatically
  • [x] Eslint
  • [x] Stylelint
  • [x] Tests

How has this been tested?

Checklist

  • [x] I submit my changes into the develop branch
  • [x] I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (see GitHub docs)
  • [x] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)

License

  • [x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.

bsekachev avatar Feb 09 '24 10:02 bsekachev

/check

bsekachev avatar Feb 09 '24 18:02 bsekachev

:x: Some checks failed :page_facing_up: See logs here

github-actions[bot] avatar Feb 09 '24 18:02 github-actions[bot]

/check

bsekachev avatar Feb 16 '24 13:02 bsekachev

:x: Some checks failed :page_facing_up: See logs here

github-actions[bot] avatar Feb 16 '24 13:02 github-actions[bot]

/check

bsekachev avatar Feb 22 '24 19:02 bsekachev

:x: Some checks failed :page_facing_up: See logs here

github-actions[bot] avatar Feb 22 '24 19:02 github-actions[bot]

[!IMPORTANT]

Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

75 files out of 132 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 09 '24 06:05 coderabbitai[bot]

@klakhov Applied

bsekachev avatar May 14 '24 11:05 bsekachev

Exclamation mark and excessive left padding now appear on organization switch modal

I believe this is new antd style: image

Major version update for package.json?

I do not see reasons to update major version. Generally all the changes are cosmetic.

bsekachev avatar May 16 '24 14:05 bsekachev

Also I cant close it without selecting something new

Applied

Do we really want to use blue hover effect?

Default antd button, I reversed it as it was with custom css.

Here I suppose using bold black font would be better instead of blue too.

The same.

If we dont have an assignee, maybe we dont want to show the line with it at all? Or at least say something like not assigned so we dont have emty space.

The main idea is to keep height the same. Sliding bottom part is annoying a little bit.

I like the idea of showing stage+state in one status row like annotation in progress or annotation rejected, it looks cool. But it looks strange with new, maybe we should use an alias for that something like annotation not started.

The main idea behind it was to keep vertical space, using horizontal free space. I would avoid customizing logic in described way.

Small padding problem on models page(it seems the same problem is on the projects page):

Fixed on projects/jobs/models. Also fixed top bars on different resolutions.

bsekachev avatar May 16 '24 15:05 bsekachev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.35%. Comparing base (f1341d5) to head (eee0294). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7466      +/-   ##
===========================================
- Coverage    83.38%   83.35%   -0.03%     
===========================================
  Files          380      381       +1     
  Lines        40034    40051      +17     
  Branches      3769     3769              
===========================================
+ Hits         33382    33386       +4     
- Misses        6652     6665      +13     
Components Coverage Δ
cvat-ui 79.27% <100.00%> (-0.05%) :arrow_down:
cvat-server 87.12% <ø> (ø)

codecov-commenter avatar May 16 '24 16:05 codecov-commenter