cvat
cvat copied to clipboard
Fix bug: Fixed a problem that was overwritten and not inputted when entering Korean
The part where Korean is separated and entered in CVAT standard workspace has been fixed in PR (https://github.com/opencv/cvat/pull/6916).
But in case of Attribuite annotation
workspace, it confirmed that the same problem still occurred and corrected it similar to the PR above.
Motivation and context
How has this been tested?
Checklist
- [x] I submit my changes into the
develop
branch - [x] I have created a changelog fragment
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see GitHub docs)
- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)
License
- [ ] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
Below is my test case when i using korean annotation in Attribuite annotation
workspace.
I'm unsure how to write test codes for the UI, so I'm attaching the results of the tests conducted on the UI below.
Before
After
Hello
Thanks for the contribution, I did minor changes, so, please the PR is still working for you.
And please, check in PR description: I submit my code changes under the same [MIT License](https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project.
Otherwise we will not be able to accept it.
Codecov Report
Merging #7380 (786c823) into develop (7286d65) will increase coverage by
0.01%
. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## develop #7380 +/- ##
===========================================
+ Coverage 83.52% 83.54% +0.01%
===========================================
Files 372 372
Lines 39666 39666
Branches 3718 3718
===========================================
+ Hits 33131 33137 +6
+ Misses 6535 6529 -6
Components | Coverage Δ | |
---|---|---|
cvat-ui | 79.43% <ø> (+0.03%) |
:arrow_up: |
cvat-server | 87.31% <ø> (ø) |
@bsekachev Thanks for update pull request. I tried again and made sure it worked fine