cvat icon indicating copy to clipboard operation
cvat copied to clipboard

Published 20 hours ago • verified publisher icon cvat-ai

Add support for Azure Blob Storage connection string authentication

Open suzusuzu opened this issue 2 years ago • 9 comments

Motivation and context

This is a change to support Connection String authentication for Azure Blob Storage. For example, Connection String Authentication allows for Azure Blob Storage running on the IoT Edge of an edge device.

How has this been tested?

I tested it by actually running it as shown in the next image, I could not find where the E2E test for cloudstorage was done. cvat_blob_connection_string

Checklist

  • [x] I submit my changes into the develop branch
  • [x] I have added a description of my changes into CHANGELOG file
  • [x] I have updated the documentation accordingly
  • [ ] I have added tests to cover my changes
  • [ ] I have linked related issues (read github docs)
  • [x] I have increased versions of npm packages if it is necessary (cvat-canvas, cvat-core, cvat-data and cvat-ui)

License

  • [x] I submit my code changes under the same MIT License that covers the project. Feel free to contact the maintainers if that's a concern.
  • [x] I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

suzusuzu avatar May 20 '22 05:05 suzusuzu

Hi, @suzusuzu, thanks for the contribution! Are you still going to contribute to us? If so, could you please resolve conflicts in this PR?

Marishka17 avatar Aug 22 '22 11:08 Marishka17

@Marishka17 Thanks for the reply, I resolved the conflict. Please check it out.

suzusuzu avatar Aug 22 '22 12:08 suzusuzu

/check

bsekachev avatar Sep 12 '22 08:09 bsekachev

:x: Some checks failed :page_facing_up: See logs here

github-actions[bot] avatar Sep 12 '22 08:09 github-actions[bot]

@kirill-sizov Can you look to full-check run? Looks like it does not work for 3rd-party PRs.

bsekachev avatar Sep 12 '22 08:09 bsekachev

/check

sizov-kirill avatar Oct 13 '22 07:10 sizov-kirill

:heavy_check_mark: All checks completed successfully :page_facing_up: See logs here

github-actions[bot] avatar Oct 13 '22 07:10 github-actions[bot]

@Marishka17 Have you already reviewed this PR? Or it requires additional review?

sizov-kirill avatar Oct 20 '22 09:10 sizov-kirill

Unfortunately, I haven't, but that was planned. Need to review and test it with a container on Azure.

Marishka17 avatar Oct 20 '22 10:10 Marishka17

@Marishka17 , let's try to find sometime next week to review the PR.

nmanovic avatar Dec 10 '22 19:12 nmanovic

@nmanovic, Ok, but in this case, I need an account on Azure for testing. I forgot to ask this again in our last meeting about this question.

Marishka17 avatar Dec 10 '22 19:12 Marishka17

@suzusuzu, One more thing, when I attach the Azure container and go to update cloud storage page field with connection string is empty.(Need add fake credentials for connection string.)

Marishka17 avatar Jan 17 '23 12:01 Marishka17

@SpecLad , your check is working :). Should @Marishka17 just update it in the case?

nmanovic avatar Mar 19 '23 07:03 nmanovic