pyndri icon indicating copy to clipboard operation
pyndri copied to clipboard

General fixes + get it working on OSX

Open MatsWillemsen opened this issue 8 years ago • 1 comments

When calling Index() failed, because Indri reports an error, do not PY_DECREF self->query_env_obj, because it is likely NULL (it gets created later), so use the safe PY_XDECREF.

Also, with clang (on OSX), it needs to be specified that the code is C++11, to understand some of the features in the code. On Ubuntu, it works out of the box.

MatsWillemsen avatar Jan 11 '17 16:01 MatsWillemsen

Thanks for your contributions. To keep things organised, can you please:

  1. Split up this issue in two separate issues (one for the installation fix, another for the reference counting fix).
  2. Remove any unnecessary commits/changes from the pull requests (e.g., adding a Homebrew file and removing it directly afterwards is just noise, the comment you add at the top of setup.py has to go, etc.).

cvangysel avatar Jan 11 '17 17:01 cvangysel