postcss-pxtorem icon indicating copy to clipboard operation
postcss-pxtorem copied to clipboard

Consider postcss-value-parser

Open davidtheclark opened this issue 8 years ago • 5 comments

I thought I'd bring this library to your attention, in case you are interested in using it to replace your pixel-unit-regex: https://github.com/TrySound/postcss-value-parser. Feel free to close if you don't need it, but wanted to make sure it was on your radar.

Nice plugin!

davidtheclark avatar Dec 05 '15 20:12 davidtheclark

Thanks! This is great, I might use it.

cuth avatar Dec 06 '15 01:12 cuth

@cuth Funny story. I saw a talk today by @lazd in which we described a Stylus method he had worked out for accomplishing this ... and I thought, "That would be a great PostCSS plugin," ... so I thought about writing it, and I told him about it and he said he might write it ... and then within a few minutes I found that you'd already done it.

davidtheclark avatar Dec 06 '15 01:12 davidtheclark

@davidtheclark your PostCSS talk slides are great. Thanks for mentioning this plugin in your talk!

cuth avatar Dec 06 '15 21:12 cuth

@cuth would you be willing to accept PR for this change? I think this could open additional possibilities to improve this plugin (e.g. alternative ways for ignoring properties).

niksy avatar Aug 12 '19 12:08 niksy

@niksy yes. Sorry for the delayed response!

Ideally, it would pass all the tests and keep the API the same. Even then, I think I would still make it a major version bump just so people have to opt into it.

Thanks for your interest!

cuth avatar Aug 22 '19 02:08 cuth